From 4740e60d07f8ae53f3bfcb268c3f1708156d621c Mon Sep 17 00:00:00 2001
From: Bram Kragten <mail@bramkragten.nl>
Date: Thu, 4 Jan 2024 10:15:21 +0100
Subject: [PATCH] fix valve

---
 src/common/const.ts |  1 +
 src/data/valve.ts   | 10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/common/const.ts b/src/common/const.ts
index bc114f2f17..2e7d2f7c77 100644
--- a/src/common/const.ts
+++ b/src/common/const.ts
@@ -254,6 +254,7 @@ export const DOMAINS_INPUT_ROW = [
   "text",
   "time",
   "vacuum",
+  "valve",
 ];
 
 /** States that we consider "off". */
diff --git a/src/data/valve.ts b/src/data/valve.ts
index 73f5d428ae..645ca82e49 100644
--- a/src/data/valve.ts
+++ b/src/data/valve.ts
@@ -14,14 +14,20 @@ export const enum ValveEntityFeature {
 }
 
 export function isFullyOpen(stateObj: ValveEntity) {
-  if (stateObj.attributes.current_position !== undefined) {
+  if (
+    stateObj.attributes.current_position !== undefined &&
+    stateObj.attributes.current_position !== null
+  ) {
     return stateObj.attributes.current_position === 100;
   }
   return stateObj.state === "open";
 }
 
 export function isFullyClosed(stateObj: ValveEntity) {
-  if (stateObj.attributes.current_position !== undefined) {
+  if (
+    stateObj.attributes.current_position !== undefined &&
+    stateObj.attributes.current_position !== null
+  ) {
     return stateObj.attributes.current_position === 0;
   }
   return stateObj.state === "closed";