From 48f5d1706085f0ff9e0f478f8dd9b778089d642c Mon Sep 17 00:00:00 2001 From: Petar Petrov Date: Wed, 11 Dec 2024 13:36:47 +0200 Subject: [PATCH] log warning when navigation is blocked --- src/common/navigate.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/common/navigate.ts b/src/common/navigate.ts index 46bf0d9b69..69710ebe1d 100644 --- a/src/common/navigate.ts +++ b/src/common/navigate.ts @@ -21,8 +21,9 @@ export const navigate = async (path: string, options?: NavigateOptions) => { if (history.state?.dialog) { const closed = await closeAllDialogs(); if (!closed) { - // block navigation if dialogs refuse to close - return; + // eslint-disable-next-line no-console + console.warn("Navigation blocked, because dialog refused to close"); + return false; } // if there were open dialogs, we discard the current state replace = true; @@ -50,4 +51,5 @@ export const navigate = async (path: string, options?: NavigateOptions) => { fireEvent(mainWindow, "location-changed", { replace, }); + return true; };