Remove narrow from strategies (#18201)

cast/src/receiver/layout/hc-main.ts

@@ -323,8 +323,7 @@ export class HcMain extends HassElement {
         {
           type: DEFAULT_STRATEGY,
         },
-        this.hass!,
+        this.hass!
-        { narrow: false }
       )
     );
   }

src/panels/lovelace/editor/hui-dialog-save-config.ts

@@ -174,9 +174,7 @@ export class HuiSaveConfig extends LitElement implements HassDialog {
       await lovelace.saveConfig(
         this._emptyConfig
           ? EMPTY_CONFIG
-          : await expandLovelaceConfigStrategies(lovelace.config, this.hass, {
+          : await expandLovelaceConfigStrategies(lovelace.config, this.hass)
-              narrow: this._params.narrow,
-            })
       );
       lovelace.setEditMode(true);
       this._saving = false;

src/panels/lovelace/ha-panel-lovelace.ts

@@ -167,8 +167,7 @@ export class LovelacePanel extends LitElement {
       {
         type: DEFAULT_STRATEGY,
       },
-      this.hass!,
+      this.hass!
-      { narrow: this.narrow }
     );
     this._setLovelaceConfig(conf, undefined, "generated");
     this._panelState = "loaded";
@@ -258,8 +257,7 @@ export class LovelacePanel extends LitElement {
       if (rawConf.strategy) {
         conf = await generateLovelaceDashboardStrategy(
           rawConf.strategy,
-          this.hass!,
+          this.hass!
-          { narrow: this.narrow }
         );
       } else {
         conf = rawConf;
@@ -276,8 +274,7 @@ export class LovelacePanel extends LitElement {
         {
           type: DEFAULT_STRATEGY,
         },
-        this.hass!,
+        this.hass!
-        { narrow: this.narrow }
       );
       confMode = "generated";
     } finally {
@@ -365,8 +362,7 @@ export class LovelacePanel extends LitElement {
         if (newConfig.strategy) {
           conf = await generateLovelaceDashboardStrategy(
             newConfig.strategy,
-            this.hass!,
+            this.hass!
-            { narrow: this.narrow }
           );
         } else {
           conf = newConfig;
@@ -404,8 +400,7 @@ export class LovelacePanel extends LitElement {
             {
               type: DEFAULT_STRATEGY,
             },
-            this.hass!,
+            this.hass!
-            { narrow: this.narrow }
           );
           this._updateLovelace({
             config: generatedConf,

src/panels/lovelace/strategies/get-strategy.ts

@@ -8,7 +8,6 @@ import { isLegacyStrategy } from "./legacy-strategy";
 import {
   LovelaceDashboardStrategy,
   LovelaceStrategy,
-  LovelaceStrategyParams,
   LovelaceViewStrategy,
 } from "./types";
 
@@ -77,8 +76,7 @@ const generateStrategy = async <T extends LovelaceStrategyConfigType>(
   configType: T,
   renderError: (err: string | Error) => StrategyConfig<T>,
   strategyConfig: LovelaceStrategyConfig,
-  hass: HomeAssistant,
+  hass: HomeAssistant
-  params: LovelaceStrategyParams
 ): Promise<StrategyConfig<T>> => {
   const strategyType = strategyConfig.type;
   if (!strategyType) {
@@ -95,7 +93,6 @@ const generateStrategy = async <T extends LovelaceStrategyConfigType>(
         return (await strategy.generateDashboard({
           config: { strategy: strategyConfig, views: [] },
           hass,
-          narrow: params.narrow,
         })) as StrategyConfig<T>;
       }
       if (configType === "view" && "generateView" in strategy) {
@@ -103,7 +100,6 @@ const generateStrategy = async <T extends LovelaceStrategyConfigType>(
           config: { views: [] },
           view: { strategy: strategyConfig },
           hass,
-          narrow: params.narrow,
         })) as StrategyConfig<T>;
       }
     }
@@ -115,7 +111,7 @@ const generateStrategy = async <T extends LovelaceStrategyConfigType>(
 
     delete config.options;
 
-    return await strategy.generate(config, hass, params);
+    return await strategy.generate(config, hass);
   } catch (err: any) {
     if (err.message !== "timeout") {
       // eslint-disable-next-line
@@ -128,8 +124,7 @@ const generateStrategy = async <T extends LovelaceStrategyConfigType>(
 
 export const generateLovelaceDashboardStrategy = async (
   strategyConfig: LovelaceStrategyConfig,
-  hass: HomeAssistant,
+  hass: HomeAssistant
-  params: LovelaceStrategyParams
 ): Promise<LovelaceConfig> =>
   generateStrategy(
     "dashboard",
@@ -147,14 +142,12 @@ export const generateLovelaceDashboardStrategy = async (
       ],
     }),
     strategyConfig,
-    hass,
+    hass
-    params
   );
 
 export const generateLovelaceViewStrategy = async (
   strategyConfig: LovelaceStrategyConfig,
-  hass: HomeAssistant,
+  hass: HomeAssistant
-  params: LovelaceStrategyParams
 ): Promise<LovelaceViewConfig> =>
   generateStrategy(
     "view",
@@ -167,8 +160,7 @@ export const generateLovelaceViewStrategy = async (
       ],
     }),
     strategyConfig,
-    hass,
+    hass
-    params
   );
 
 /**
@@ -176,18 +168,15 @@ export const generateLovelaceViewStrategy = async (
  */
 export const expandLovelaceConfigStrategies = async (
   config: LovelaceConfig,
-  hass: HomeAssistant,
+  hass: HomeAssistant
-  params: LovelaceStrategyParams
 ): Promise<LovelaceConfig> => {
   const newConfig = config.strategy
-    ? await generateLovelaceDashboardStrategy(config.strategy, hass, params)
+    ? await generateLovelaceDashboardStrategy(config.strategy, hass)
     : { ...config };
 
   newConfig.views = await Promise.all(
     newConfig.views.map((view) =>
-      view.strategy
+      view.strategy ? generateLovelaceViewStrategy(view.strategy, hass) : view
-        ? generateLovelaceViewStrategy(view.strategy, hass, params)
-        : view
     )
   );
 

src/panels/lovelace/strategies/legacy-strategy.ts

@@ -10,7 +10,6 @@ export interface LovelaceDashboardStrategy {
   generateDashboard(info: {
     config?: LovelaceConfig;
     hass: HomeAssistant;
-    narrow: boolean | undefined;
   }): Promise<LovelaceConfig>;
 }
 
@@ -19,6 +18,5 @@ export interface LovelaceViewStrategy {
     view: LovelaceViewConfig;
     config: LovelaceConfig;
     hass: HomeAssistant;
-    narrow: boolean | undefined;
   }): Promise<LovelaceViewConfig>;
 }

src/panels/lovelace/strategies/original-states-dashboard-strategy.ts

@@ -2,14 +2,12 @@ import { ReactiveElement } from "lit";
 import { customElement } from "lit/decorators";
 import { LovelaceConfig, LovelaceStrategyConfig } from "../../../data/lovelace";
 import { HomeAssistant } from "../../../types";
-import { LovelaceStrategyParams } from "./types";
 
 @customElement("original-states-dashboard-strategy")
 export class OriginalStatesDashboardStrategy extends ReactiveElement {
   static async generate(
     _config: LovelaceStrategyConfig,
-    hass: HomeAssistant,
+    hass: HomeAssistant
-    _params?: LovelaceStrategyParams
   ): Promise<LovelaceConfig> {
     return {
       title: hass.config.location_name,

src/panels/lovelace/strategies/original-states-view-strategy.ts

@@ -9,14 +9,12 @@ import {
 } from "../../../data/lovelace";
 import { HomeAssistant } from "../../../types";
 import { generateDefaultViewConfig } from "../common/generate-lovelace-config";
-import { LovelaceStrategyParams } from "./types";
 
 @customElement("original-states-view-strategy")
 export class OriginalStatesViewStrategy extends ReactiveElement {
   static async generate(
     _config: LovelaceStrategyConfig,
-    hass: HomeAssistant,
+    hass: HomeAssistant
-    _params?: LovelaceStrategyParams
   ): Promise<LovelaceViewConfig> {
     if (hass.config.state === STATE_NOT_RUNNING) {
       return {

src/panels/lovelace/strategies/types.ts

@@ -5,16 +5,8 @@ import {
 } from "../../../data/lovelace";
 import { HomeAssistant } from "../../../types";
 
-export type LovelaceStrategyParams = {
-  narrow?: boolean;
-};
-
 export type LovelaceStrategy<T = any> = {
-  generate(
+  generate(config: LovelaceStrategyConfig, hass: HomeAssistant): Promise<T>;
-    config: LovelaceStrategyConfig,
-    hass: HomeAssistant,
-    params?: LovelaceStrategyParams
-  ): Promise<T>;
 };
 
 export interface LovelaceDashboardStrategy

src/panels/lovelace/views/hui-view.ts

@@ -192,8 +192,7 @@ export class HUIView extends ReactiveElement {
       isStrategy = true;
       viewConfig = await generateLovelaceViewStrategy(
         viewConfig.strategy,
-        this.hass!,
+        this.hass!
-        { narrow: this.narrow }
       );
     }