jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-25 18:26:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix hui-energy-compare-card (#24711)

Browse Source 
* Fix hui-energy-compare-card

* rename var
This commit is contained in:
karwosts 2025-03-24 07:14:18 -07:00 committed by GitHub
parent e0fbd3cd1f
commit 4c952c191a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/panels/lovelace/cards/energy/hui-energy-compare-card.ts
View File

@ -12,6 +12,7 @@ import type { LovelaceCard } from "../../types";
import type { EnergyCardBaseConfig } from "../types"; import type { EnergyCardBaseConfig } from "../types";
import { hasConfigChanged } from "../../common/has-changed"; import { hasConfigChanged } from "../../common/has-changed";
import "../../../../components/ha-alert"; import "../../../../components/ha-alert";
import { fireEvent } from "../../../../common/dom/fire_event";
@customElement("hui-energy-compare-card") @customElement("hui-energy-compare-card")
export class HuiEnergyCompareCard export class HuiEnergyCompareCard
@ -33,6 +34,11 @@ export class HuiEnergyCompareCard
// eslint-disable-next-line lit/no-native-attributes // eslint-disable-next-line lit/no-native-attributes
@property({ type: Boolean, reflect: true }) hidden = true; @property({ type: Boolean, reflect: true }) hidden = true;
// Energy compare card cannot tolerate being removed from the DOM by hui-card,
// as it calculates its own visibility and needs an active collection
// subscription to do so.
connectedWhileHidden = true;
public getCardSize(): Promise<number> | number { public getCardSize(): Promise<number> | number {
return 1; return 1;
} }
@ -106,7 +112,11 @@ export class HuiEnergyCompareCard
this._end = data.end; this._end = data.end;
this._startCompare = data.startCompare; this._startCompare = data.startCompare;
this._endCompare = data.endCompare; this._endCompare = data.endCompare;
const oldHidden = this.hidden;
this.hidden = !this._startCompare; this.hidden = !this._startCompare;
if (oldHidden !== this.hidden) {
fireEvent(this, "card-visibility-changed");
}
} }
private _stopCompare(): void { private _stopCompare(): void {

6
src/panels/lovelace/cards/hui-card.ts
View File

@ -270,7 +270,11 @@ export class HuiCard extends ReactiveElement {
fireEvent(this, "card-visibility-changed", { value: visible }); fireEvent(this, "card-visibility-changed", { value: visible });
} }
if (!visible && this._element.parentElement) { if (this._element.connectedWhileHidden === true) {
if (!this._element.parentElement) {
this.appendChild(this._element);
}
} else if (!visible && this._element.parentElement) {
this.removeChild(this._element); this.removeChild(this._element);
} else if (visible && !this._element.parentElement) { } else if (visible && !this._element.parentElement) {
this.appendChild(this._element); this.appendChild(this._element);

1
src/panels/lovelace/types.ts
View File

@ -65,6 +65,7 @@ export interface LovelaceCard extends HTMLElement {
hass?: HomeAssistant; hass?: HomeAssistant;
preview?: boolean; preview?: boolean;
layout?: string; layout?: string;
connectedWhileHidden?: boolean;
getCardSize(): number | Promise<number>; getCardSize(): number | Promise<number>;
/** @deprecated Use `getGridOptions` instead */ /** @deprecated Use `getGridOptions` instead */
getLayoutOptions?(): LovelaceLayoutOptions; getLayoutOptions?(): LovelaceLayoutOptions;