jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-24 17:56:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
This commit is contained in:
Erik Montnemery 2022-02-18 15:57:57 +01:00 committed by GitHub
parent 246724c59e
commit 4f6a241817
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/panels/config/devices/ha-config-device-page.ts
View File

@ -276,26 +276,14 @@ export class HaConfigDevicePage extends LitElement {
return; return;
} }
let buttons = this._integrations(device, this.entries).map((entry) => { const buttons = this._integrations(device, this.entries).forEach((entry) => {
if (entry.state !== "loaded" || !entry.supports_remove_device) { if (entry.state !== "loaded" || !entry.supports_remove_device) {
return false; return;
} }
return { buttons.push(html`
entry_id: entry.entry_id,
domain: entry.domain,
};
});
buttons = buttons.filter(Boolean);
if (buttons.length > 0) {
this._deleteButtons = (
buttons as { entry_id: string; domain: string }[]
).map(
(button) => html`
<mwc-button <mwc-button
class="warning" class="warning"
entry_id=${button.entry_id} .entryId=${entry.entry_id}
@click=${this._confirmDeleteEntry} @click=${this._confirmDeleteEntry}
> >
${buttons.length > 1 ${buttons.length > 1
@ -304,19 +292,22 @@ export class HaConfigDevicePage extends LitElement {
{ {
integration: domainToName( integration: domainToName(
this.hass.localize, this.hass.localize,
button.domain entry.domain
), ),
} }
) )
: this.hass.localize(`ui.panel.config.devices.delete_device`)} : this.hass.localize(`ui.panel.config.devices.delete_device`)}
</mwc-button> </mwc-button>
` `);
); });
if (buttons.length > 0) {
this._deleteButtons = buttons;
} }
} }
private async _confirmDeleteEntry(e: MouseEvent): Promise<void> { private async _confirmDeleteEntry(e: MouseEvent): Promise<void> {
const entry_id = (e.currentTarget! as HTMLElement).getAttribute("entry_id"); const entryId = (e.currentTarget as any). entryId;
const confirmed = await showConfirmationDialog(this, { const confirmed = await showConfirmationDialog(this, {
text: this.hass.localize("ui.panel.config.devices.confirm_delete"), text: this.hass.localize("ui.panel.config.devices.confirm_delete"),
@ -326,7 +317,7 @@ export class HaConfigDevicePage extends LitElement {
return; return;
} }
await removeConfigEntryFromDevice(this.hass!, this.deviceId, entry_id!); await removeConfigEntryFromDevice(this.hass!, this.deviceId, entryId);
} }
protected firstUpdated(changedProps) { protected firstUpdated(changedProps) {