From 5bb5d6800c955c14e712055929a642bc5c722677 Mon Sep 17 00:00:00 2001
From: Robbie Trencheny <me@robbiet.us>
Date: Wed, 17 Aug 2016 14:37:08 -0700
Subject: [PATCH] Improve readability, add data support to callbacks, remove
 notification from the type

---
 script/service-worker.js.tmpl | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/script/service-worker.js.tmpl b/script/service-worker.js.tmpl
index cee00288fc..b61254ea1b 100644
--- a/script/service-worker.js.tmpl
+++ b/script/service-worker.js.tmpl
@@ -5,7 +5,11 @@ self.addEventListener("push", function(event) {
     event.waitUntil(
       self.registration.showNotification(data.title, data)
       .then(function(notification){
-        firePushCallback({type: "push", tag: data.tag}, data.data.jwt);
+        firePushCallback({
+          type: "push",
+          tag: data.tag,
+          data: data.data
+        }, data.data.jwt);
       })
     );
   }
@@ -51,16 +55,23 @@ self.addEventListener('notificationclose', function(event) {
 
 function notificationEventCallback(event){
   firePushCallback({
-    type: event.type,
+    action: event.action,
+    data: event.notification.data,
     tag: event.notification.tag,
-    action: event.action
+    type: event.type.replace("notification", "")
   }, event.notification.data.jwt);
 }
-function firePushCallback(data, jwt){
+function firePushCallback(payload, jwt){
+  // Don't send the JWT in the payload.data
+  delete payload.data.jwt;
+  // If payload.data is empty then just remove the entire payload.data object.
+  if (Object.keys(payload.data).length === 0 && payload.data.constructor === Object) {
+    delete payload.data;
+  }
   fetch('/api/notify.html5/callback', {
     method: 'POST',
     headers: new Headers({'Content-Type': 'application/json',
                           'Authorization': 'Bearer '+jwt}),
-    body: JSON.stringify(data)
+    body: JSON.stringify(payload)
   });
 }