Refactor getStatisticLabel (#13486)

This commit is contained in:
Erik Montnemery 2022-08-25 14:53:16 +02:00 committed by GitHub
parent a8833a5ec1
commit 5d1536030a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 26 additions and 27 deletions

View File

@ -238,11 +238,7 @@ class StatisticsChart extends LitElement {
);
let name = names[firstStat.statistic_id];
if (!name) {
const tmp: Record<string, StatisticsMetaData> = {};
if (meta) {
tmp[firstStat.statistic_id] = meta;
}
name = getStatisticLabel(this.hass, firstStat.statistic_id, tmp);
name = getStatisticLabel(this.hass, firstStat.statistic_id, meta);
}
if (!this.unit) {

View File

@ -569,12 +569,11 @@ export const adjustStatisticsSum = (
export const getStatisticLabel = (
hass: HomeAssistant,
statisticsId: string,
statisticsMetaData: Record<string, StatisticsMetaData> | undefined
statisticsMetaData: StatisticsMetaData | undefined
): string => {
const entity = hass.states[statisticsId];
if (entity) {
return computeStateName(entity);
}
const statisticMetaData = statisticsMetaData?.[statisticsId];
return statisticMetaData?.name || statisticsId;
return statisticsMetaData?.name || statisticsId;
};

View File

@ -104,14 +104,14 @@ export class EnergyBatterySettings extends LitElement {
>${getStatisticLabel(
this.hass,
source.stat_energy_from,
this.statsMetadata
this.statsMetadata[source.stat_energy_from]
)}</span
>
<span
>${getStatisticLabel(
this.hass,
source.stat_energy_to,
this.statsMetadata
this.statsMetadata[source.stat_energy_to]
)}</span
>
</div>

View File

@ -90,7 +90,7 @@ export class EnergyDeviceSettings extends LitElement {
>${getStatisticLabel(
this.hass,
device.stat_consumption,
this.statsMetadata
this.statsMetadata[device.stat_consumption]
)}</span
>
<ha-icon-button

View File

@ -98,7 +98,7 @@ export class EnergyGasSettings extends LitElement {
>${getStatisticLabel(
this.hass,
source.stat_energy_from,
this.statsMetadata
this.statsMetadata[source.stat_energy_from]
)}</span
>
<ha-icon-button

View File

@ -136,7 +136,7 @@ export class EnergyGridSettings extends LitElement {
>${getStatisticLabel(
this.hass,
flow.stat_energy_from,
this.statsMetadata
this.statsMetadata[flow.stat_energy_from]
)}</span
>
<ha-icon-button
@ -183,7 +183,7 @@ export class EnergyGridSettings extends LitElement {
>${getStatisticLabel(
this.hass,
flow.stat_energy_to,
this.statsMetadata
this.statsMetadata[flow.stat_energy_to]
)}</span
>
<ha-icon-button

View File

@ -106,7 +106,7 @@ export class EnergySolarSettings extends LitElement {
>${getStatisticLabel(
this.hass,
source.stat_energy_from,
this.statsMetadata
this.statsMetadata[source.stat_energy_from]
)}</span
>
${this.info

View File

@ -116,7 +116,7 @@ export class HuiEnergyDevicesGraphCard
return getStatisticLabel(
this.hass,
statisticId as any,
this._data?.statsMetadata
this._data?.statsMetadata[statisticId]
);
},
},
@ -138,7 +138,7 @@ export class HuiEnergyDevicesGraphCard
return getStatisticLabel(
this.hass,
statisticId,
this._data?.statsMetadata
this._data?.statsMetadata[statisticId]
);
},
label: (context) =>

View File

@ -382,7 +382,7 @@ export class HuiEnergyGasGraphCard
label: getStatisticLabel(
this.hass,
source.stat_energy_from,
statisticsMetaData
statisticsMetaData[source.stat_energy_from]
),
borderColor: compare ? borderColor + "7F" : borderColor,
backgroundColor: compare ? borderColor + "32" : borderColor + "7F",

View File

@ -405,7 +405,7 @@ export class HuiEnergySolarGraphCard
name: getStatisticLabel(
this.hass,
source.stat_energy_from,
statisticsMetaData
statisticsMetaData[source.stat_energy_from]
),
}
),
@ -483,7 +483,7 @@ export class HuiEnergySolarGraphCard
name: getStatisticLabel(
this.hass,
source.stat_energy_from,
statisticsMetaData
statisticsMetaData[source.stat_energy_from]
),
}
),

View File

@ -239,7 +239,7 @@ export class HuiEnergySourcesTableCard
${getStatisticLabel(
this.hass,
source.stat_energy_from,
this._data?.statsMetadata
this._data?.statsMetadata[source.stat_energy_from]
)}
</th>
${compare
@ -347,7 +347,7 @@ export class HuiEnergySourcesTableCard
${getStatisticLabel(
this.hass,
source.stat_energy_from,
this._data?.statsMetadata
this._data?.statsMetadata[source.stat_energy_from]
)}
</th>
${compare
@ -384,7 +384,7 @@ export class HuiEnergySourcesTableCard
${getStatisticLabel(
this.hass,
source.stat_energy_to,
this._data?.statsMetadata
this._data?.statsMetadata[source.stat_energy_to]
)}
</th>
${compare
@ -505,7 +505,7 @@ export class HuiEnergySourcesTableCard
${getStatisticLabel(
this.hass,
flow.stat_energy_from,
this._data?.statsMetadata
this._data?.statsMetadata[flow.stat_energy_from]
)}
</th>
${compare
@ -610,7 +610,7 @@ export class HuiEnergySourcesTableCard
${getStatisticLabel(
this.hass,
flow.stat_energy_to,
this._data?.statsMetadata
this._data?.statsMetadata[flow.stat_energy_to]
)}
</th>
${compare
@ -763,7 +763,7 @@ export class HuiEnergySourcesTableCard
${getStatisticLabel(
this.hass,
source.stat_energy_from,
this._data?.statsMetadata
this._data?.statsMetadata[source.stat_energy_from]
)}
</th>
${compare

View File

@ -620,7 +620,11 @@ export class HuiEnergyUsageGraphCard
label:
type in labels
? labels[type]
: getStatisticLabel(this.hass, statId, statisticsMetaData),
: getStatisticLabel(
this.hass,
statId,
statisticsMetaData[statId]
),
order:
type === "used_solar"
? 1