Use manifest.issue_tracker for issues URL if not built_in (#5818)

This commit is contained in:
Joakim Sørensen 2020-05-11 13:45:00 +02:00 committed by GitHub
parent 2d627819d9
commit 60be14dc77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 11 deletions

View File

@ -18,7 +18,11 @@ export interface IntegrationManifest {
quality_scale?: string; quality_scale?: string;
} }
export const integrationIssuesUrl = (domain: string) => export const integrationIssuesUrl = (
domain: string,
manifest: IntegrationManifest
) =>
manifest.issue_tracker ||
`https://github.com/home-assistant/home-assistant/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+${domain}%22`; `https://github.com/home-assistant/home-assistant/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+${domain}%22`;
export const domainToName = (localize: LocalizeFunc, domain: string) => export const domainToName = (localize: LocalizeFunc, domain: string) =>

View File

@ -71,12 +71,14 @@ class IntegrationsCard extends LitElement {
)} )}
</a> </a>
</td> </td>
${!manifest.is_built_in ${manifest.is_built_in || manifest.issue_tracker
? "" ? html`
: html`
<td> <td>
<a <a
href=${integrationIssuesUrl(domain)} href=${integrationIssuesUrl(
domain,
manifest
)}
target="_blank" target="_blank"
rel="noreferrer" rel="noreferrer"
> >
@ -85,7 +87,8 @@ class IntegrationsCard extends LitElement {
)} )}
</a> </a>
</td> </td>
`} `
: ""}
`} `}
</tr> </tr>
`; `;

View File

@ -84,15 +84,19 @@ class DialogSystemLogDetail extends LitElement {
target="_blank" target="_blank"
rel="noreferrer" rel="noreferrer"
>documentation</a >documentation</a
>${!this._manifest.is_built_in >${this._manifest.is_built_in ||
? "" this._manifest.issue_tracker
: html`, ? html`,
<a <a
href=${integrationIssuesUrl(integration)} href=${integrationIssuesUrl(
integration,
this._manifest
)}
target="_blank" target="_blank"
rel="noreferrer" rel="noreferrer"
>issues</a >issues</a
>`}) >`
: ""})
`} `}
` `
: ""} : ""}