jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-09 02:16:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix language selection (#1056)

Browse Source 
* fix attr-for-selected not finding language-tag

* look for attribute instead of property

* change to data-binding structure
This commit is contained in:
NovapaX 2018-04-01 02:31:27 +02:00 committed by Paulus Schoutsen
parent d8fb01ab44
commit 6447e98caa
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
panels/config/core/ha-config-section-translation.html
View File

@ -18,7 +18,7 @@
<paper-card> <paper-card>
<div class='card-content'> <div class='card-content'>
<paper-dropdown-menu label="[[localize('ui.panel.config.core.section.translation.language')]]" dynamic-align> <paper-dropdown-menu label="[[localize('ui.panel.config.core.section.translation.language')]]" dynamic-align>
<paper-listbox slot="dropdown-content" on-selected-item-changed="handleLanguageSelect" attr-for-selected="language-tag" selected="[[language]]"> <paper-listbox slot="dropdown-content" attr-for-selected="language-tag" selected="{{languageSelection}}">
<template is='dom-repeat' items='[[languages]]'> <template is='dom-repeat' items='[[languages]]'>
<paper-item language-tag$="[[item.tag]]">[[item.nativeName]]</paper-item> <paper-item language-tag$="[[item.tag]]">[[item.nativeName]]</paper-item>
</template> </template>
@ -48,13 +48,17 @@ class HaConfigSectionTranslation extends
isWide: { isWide: {
type: Boolean, type: Boolean,
}, },
languageSelection: {
type: String,
observer: 'languageSelectionChanged',
},
languages: { languages: {
type: Array, type: Array,
computed: 'computeLanguages(hass)', computed: 'computeLanguages(hass)',
}, },
}; };
} }
static get observers() { return ['setLanguageSelection(language)']; }
computeLanguages(hass) { computeLanguages(hass) {
if (!hass || !hass.translationMetadata) { if (!hass || !hass.translationMetadata) {
@ -66,11 +70,15 @@ class HaConfigSectionTranslation extends
})); }));
} }
handleLanguageSelect(ev) { setLanguageSelection(language) {
this.languageSelection = language;
}
languageSelectionChanged(newVal) {
// Only fire event if language was changed. This prevents select updates when // Only fire event if language was changed. This prevents select updates when
// responding to hass changes. // responding to hass changes.
if (ev.detail.value && ev.detail.value.languageTag !== this.language) { if (newVal !== this.language) {
this.fire('hass-language-select', { language: ev.detail.value.languageTag }); this.fire('hass-language-select', { language: newVal });
} }
} }
} }