From 66db8c999faa3243e3b071300de85575f16ad329 Mon Sep 17 00:00:00 2001
From: Paul Bottein <paul.bottein@gmail.com>
Date: Tue, 6 Sep 2022 12:24:03 +0200
Subject: [PATCH] Open external device configuration url to a new tab/window
 (#13613)

* Open external device configuration url to a new tab/window

* Remove rel in action options
---
 .../config/devices/ha-config-device-page.ts   | 22 +++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/src/panels/config/devices/ha-config-device-page.ts b/src/panels/config/devices/ha-config-device-page.ts
index dae63448dd..2e6fd4f8b4 100644
--- a/src/panels/config/devices/ha-config-device-page.ts
+++ b/src/panels/config/devices/ha-config-device-page.ts
@@ -80,6 +80,7 @@ export interface EntityRegistryStateEntry extends EntityRegistryEntry {
 
 export interface DeviceAction {
   href?: string;
+  target?: string;
   action?: (ev: any) => void;
   label: string;
   icon?: string;
@@ -699,7 +700,15 @@ export class HaConfigDevicePage extends LitElement {
                     ? html`
                         <div class="card-actions" slot="actions">
                           <div>
-                            <a href=${ifDefined(firstDeviceAction!.href)}>
+                            <a
+                              href=${ifDefined(firstDeviceAction!.href)}
+                              rel=${ifDefined(
+                                firstDeviceAction!.target
+                                  ? "noreferrer"
+                                  : undefined
+                              )}
+                              target=${ifDefined(firstDeviceAction!.target)}
+                            >
                               <mwc-button
                                 class=${ifDefined(firstDeviceAction!.classes)}
                                 .action=${firstDeviceAction!.action}
@@ -742,7 +751,15 @@ export class HaConfigDevicePage extends LitElement {
                                   ></ha-icon-button>
                                   ${actions.map(
                                     (deviceAction) => html`
-                                      <a href=${ifDefined(deviceAction.href)}>
+                                      <a
+                                        href=${ifDefined(deviceAction.href)}
+                                        target=${ifDefined(deviceAction.target)}
+                                        rel=${ifDefined(
+                                          deviceAction.target
+                                            ? "noreferrer"
+                                            : undefined
+                                        )}
+                                      >
                                         <mwc-list-item
                                           class=${ifDefined(
                                             deviceAction.classes
@@ -981,6 +998,7 @@ export class HaConfigDevicePage extends LitElement {
     if (configurationUrl) {
       deviceActions.push({
         href: configurationUrl,
+        target: configurationUrlIsHomeAssistant ? undefined : "_blank",
         icon: mdiCog,
         label: this.hass.localize(
           "ui.panel.config.devices.open_configuration_url"