From 68302d089672865064d92ec1f47c0aa52558b0cd Mon Sep 17 00:00:00 2001 From: Paul Bottein Date: Tue, 25 Oct 2022 12:24:08 +0200 Subject: [PATCH] Fix more info dialog edit button for script (#14180) --- src/dialogs/more-info/const.ts | 2 +- src/dialogs/more-info/ha-more-info-dialog.ts | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/dialogs/more-info/const.ts b/src/dialogs/more-info/const.ts index 2d9a8d4295..15ba2da551 100644 --- a/src/dialogs/more-info/const.ts +++ b/src/dialogs/more-info/const.ts @@ -12,7 +12,7 @@ export const EDITABLE_DOMAINS_WITH_ID = ["scene", "automation"]; /** * Entity Domains that should always be editable; {@see shouldShowEditIcon}. * */ -export const EDITABLE_DOMAINS = ["script"]; +export const EDITABLE_DOMAINS_WITH_UNIQUE_ID = ["script"]; /** Domains with separate more info dialog. */ export const DOMAINS_WITH_MORE_INFO = [ diff --git a/src/dialogs/more-info/ha-more-info-dialog.ts b/src/dialogs/more-info/ha-more-info-dialog.ts index 04ad2d5a2a..f29a613c24 100644 --- a/src/dialogs/more-info/ha-more-info-dialog.ts +++ b/src/dialogs/more-info/ha-more-info-dialog.ts @@ -19,7 +19,7 @@ import "../../state-summary/state-card-content"; import { HomeAssistant } from "../../types"; import { EDITABLE_DOMAINS_WITH_ID, - EDITABLE_DOMAINS, + EDITABLE_DOMAINS_WITH_UNIQUE_ID, DOMAINS_WITH_MORE_INFO, computeShowHistoryComponent, computeShowLogBookComponent, @@ -72,7 +72,7 @@ export class MoreInfoDialog extends LitElement { if (EDITABLE_DOMAINS_WITH_ID.includes(domain) && stateObj.attributes.id) { return true; } - if (EDITABLE_DOMAINS.includes(domain)) { + if (EDITABLE_DOMAINS_WITH_UNIQUE_ID.includes(domain)) { return true; } if (domain === "person" && stateObj.attributes.editable !== "false") { @@ -246,6 +246,9 @@ export class MoreInfoDialog extends LitElement { if (EDITABLE_DOMAINS_WITH_ID.includes(domain) || domain === "person") { idToPassThroughUrl = stateObj.attributes.id; } + if (EDITABLE_DOMAINS_WITH_UNIQUE_ID.includes(domain)) { + idToPassThroughUrl = this.hass.entities[this._entityId!].unique_id; + } navigate(`/config/${domain}/edit/${idToPassThroughUrl}`); this.closeDialog();