From 6fe4f94d5519437f6216c6e25bc98d54515213b7 Mon Sep 17 00:00:00 2001
From: Norbert Rittel <norbert@rittel.de>
Date: Thu, 26 Dec 2024 15:16:50 +0100
Subject: [PATCH] Fix misleading use of "hidden" and "not shown" for disabled
 entities (#23449)

* Fix misleading use of "hidden" for disabled entities

Entities can be either hidden (by turning off "Visible") or disabled (by turning off "Enabled"),

The stings file uses the very misleading key "hidden_entities" for the count of disabled entities plus the words "not shown" which also pair with "hidden" instead of "disabled".

This commit fixes this by using "disabled" for both the key and in the link shown here.

* Replace "hidden_entities" with "disabled_entities"

Entities can be either hidden (by turning off "Visible") or disabled (by turning off "Enabled"),

The strings file uses the very misleading key "hidden_entities" for the count of disabled entities plus the words "not shown" which also pair with "hidden" instead of "disabled".

This commit fixes this by using "disabled" for the key name as well.

* Re-add accidentally deleted comma
---
 .../config/devices/device-detail/ha-device-entities-card.ts     | 2 +-
 src/translations/en.json                                        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/panels/config/devices/device-detail/ha-device-entities-card.ts b/src/panels/config/devices/device-detail/ha-device-entities-card.ts
index 55f1a2ec5b..1bac107628 100644
--- a/src/panels/config/devices/device-detail/ha-device-entities-card.ts
+++ b/src/panels/config/devices/device-detail/ha-device-entities-card.ts
@@ -107,7 +107,7 @@ export class HaDeviceEntitiesCard extends LitElement {
                 ? html`
                     <button class="show-more" @click=${this._toggleShowHidden}>
                       ${this.hass.localize(
-                        "ui.panel.config.devices.entities.hidden_entities",
+                        "ui.panel.config.devices.entities.disabled_entities",
                         { count: hiddenEntities.length }
                       )}
                     </button>
diff --git a/src/translations/en.json b/src/translations/en.json
index 9cb1081522..6227fff0e7 100644
--- a/src/translations/en.json
+++ b/src/translations/en.json
@@ -4331,7 +4331,7 @@
             "add_entities_lovelace": "Add to dashboard",
             "none": "This device has no entities",
             "show_less": "Show less",
-            "hidden_entities": "+{count} {count, plural,\n  one {entity}\n  other {entities}\n} not shown",
+            "disabled_entities": "+{count} disabled {count, plural,\n  one {entity}\n  other {entities}\n}",
             "hidden": "Hidden"
           },
           "confirm_rename_entity_ids": "Do you also want to rename the entity IDs of your entities?",