mirror of
https://github.com/home-assistant/frontend.git
synced 2025-04-26 06:17:20 +00:00
Don't allow UI editor for service calls with templates (#8581)
This commit is contained in:
parent
aece3a37c0
commit
7ea1ece169
17
src/common/string/has-template.ts
Normal file
17
src/common/string/has-template.ts
Normal file
@ -0,0 +1,17 @@
|
|||||||
|
const isTemplateRegex = new RegExp("{%|{{|{#");
|
||||||
|
export const isTemplate = (value: string): boolean =>
|
||||||
|
isTemplateRegex.test(value);
|
||||||
|
|
||||||
|
export const hasTemplate = (value: unknown): boolean => {
|
||||||
|
if (!value) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
if (typeof value === "string") {
|
||||||
|
return isTemplate(value);
|
||||||
|
}
|
||||||
|
if (typeof value === "object") {
|
||||||
|
const values = Array.isArray(value) ? value : Object.values(value!);
|
||||||
|
return values.some((val) => hasTemplate(val));
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
};
|
@ -16,6 +16,7 @@ import type { HomeAssistant } from "../../../../../types";
|
|||||||
import { EntityIdOrAll } from "../../../../../common/structs/is-entity-id";
|
import { EntityIdOrAll } from "../../../../../common/structs/is-entity-id";
|
||||||
import { ActionElement } from "../ha-automation-action-row";
|
import { ActionElement } from "../ha-automation-action-row";
|
||||||
import "../../../../../components/ha-service-control";
|
import "../../../../../components/ha-service-control";
|
||||||
|
import { hasTemplate } from "../../../../../common/string/has-template";
|
||||||
|
|
||||||
const actionStruct = object({
|
const actionStruct = object({
|
||||||
service: optional(string()),
|
service: optional(string()),
|
||||||
@ -46,6 +47,15 @@ export class HaServiceAction extends LitElement implements ActionElement {
|
|||||||
assert(this.action, actionStruct);
|
assert(this.action, actionStruct);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
fireEvent(this, "ui-mode-not-available", error);
|
fireEvent(this, "ui-mode-not-available", error);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
if (this.action && hasTemplate(this.action)) {
|
||||||
|
fireEvent(
|
||||||
|
this,
|
||||||
|
"ui-mode-not-available",
|
||||||
|
Error(this.hass.localize("ui.errors.config.no_template_editor_support"))
|
||||||
|
);
|
||||||
|
return;
|
||||||
}
|
}
|
||||||
if (this.action.entity_id) {
|
if (this.action.entity_id) {
|
||||||
this._action = {
|
this._action = {
|
||||||
|
Loading…
x
Reference in New Issue
Block a user