jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-24 09:46:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

More info panel: Replace "Dismiss dialog" tooltip with "Close info" (#24449)

Browse Source 
* More info panel: Replace "Dismiss dialog" tooltip with "Close info"

Dismiss should only be used for closing dialogs like notifications that cannot be reopened.

Therefore the "Dismiss dialog" tooltip for the More info dialog is misleading, especially in translations that might emphasize the destructive meaning of "dismiss".

Matching the "Back to info" tooltip shown to return to the initial view from the entity settings this is changed to "Close info".

* use common close

---------

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
This commit is contained in:
Norbert Rittel 2025-02-28 16:06:03 +01:00 committed by Bram Kragten
parent 56eef4bf31
commit 7f7575dcbc
4 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/dialogs/config-flow/dialog-data-entry-flow.ts
View File

@ -229,9 +229,7 @@ class DataEntryFlowDialog extends LitElement {
`
: ""}
<ha-icon-button
.label=${this.hass.localize(
"ui.panel.config.integrations.config_flow.dismiss"
)}
.label=${this.hass.localize("ui.common.close")}
.path=${mdiClose}
dialogAction="close"
></ha-icon-button>

4
src/dialogs/more-info/ha-more-info-dialog.ts
View File

@ -307,9 +307,7 @@ export class MoreInfoDialog extends LitElement {
<ha-icon-button
slot="navigationIcon"
dialogAction="cancel"
.label=${this.hass.localize(
"ui.dialogs.more_info_control.dismiss"
)}
.label=${this.hass.localize("ui.common.close")}
.path=${mdiClose}
></ha-icon-button>
`

2
src/panels/config/integrations/integration-panels/zha/dialog-zha-manage-zigbee-device.ts
View File

@ -95,7 +95,7 @@ class DialogZHAManageZigbeeDevice extends LitElement {
<ha-icon-button
slot="navigationIcon"
dialogAction="cancel"
.label=${this.hass.localize("ui.dialogs.more_info_control.dismiss")}
.label=${this.hass.localize("ui.common.close")}
.path=${mdiClose}
></ha-icon-button>
<span

6
src/translations/en.json
View File

@ -1256,7 +1256,6 @@
"clear": "Clear"
},
"more_info_control": {
"dismiss": "Dismiss dialog",
"settings": "Settings",
"edit": "Edit entity",
"details": "Details",
@ -1390,7 +1389,6 @@
"settings": "Settings",
"control": "Control",
"related": "Related",
"dismiss": "Dismiss",
"no_unique_id": "This entity (''{entity_id}'') does not have a unique ID, therefore its settings cannot be managed from the UI. See the {faq_link} for more detail.",
"faq": "documentation",
"editor": {
@ -3151,7 +3149,6 @@
"detail": {
"edit_dashboard": "Edit dashboard",
"new_dashboard": "Add new dashboard",
"dismiss": "Close",
"show_sidebar": "Show in sidebar",
"icon": "Icon",
"title": "Title",
@ -3193,7 +3190,6 @@
"detail": {
"new_resource": "Add new resource",
"edit_resource": "Edit resource",
"dismiss": "Close",
"warning_header": "Be cautious!",
"warning_text": "Adding resources can be dangerous, make sure you know the source of the resource and trust them. Bad resources could seriously harm your system.",
"url": "URL",
@ -4552,7 +4548,6 @@
"introduction2a": ", a company founded by the founders of Home Assistant.",
"introduction3": "Home Assistant Cloud is a subscription service with a free one month trial. No payment information necessary.",
"learn_more_link": "Learn more about Home Assistant Cloud",
"dismiss": "Dismiss",
"sign_in": "Sign in",
"email": "Email",
"email_error_msg": "Invalid email",
@ -5194,7 +5189,6 @@
"success": "Success",
"aborted": "Aborted",
"close": "Close",
"dismiss": "Dismiss dialog",
"finish": "Finish",
"submit": "Submit",
"next": "Next",