From 83570f2419d2d1964afe196fe77ea8fab42be626 Mon Sep 17 00:00:00 2001
From: Paul Bottein <paul.bottein@gmail.com>
Date: Fri, 26 May 2023 23:01:52 +0200
Subject: [PATCH] Add missing translations for effect and preset translation in
 more info (#16634)

---
 .../more-info/controls/more-info-fan.ts       | 22 ++++++++----
 .../more-info/controls/more-info-light.ts     | 36 ++++++++++++++-----
 2 files changed, 42 insertions(+), 16 deletions(-)

diff --git a/src/dialogs/more-info/controls/more-info-fan.ts b/src/dialogs/more-info/controls/more-info-fan.ts
index 15c3a1af42..af32733d77 100644
--- a/src/dialogs/more-info/controls/more-info-fan.ts
+++ b/src/dialogs/more-info/controls/more-info-fan.ts
@@ -276,13 +276,21 @@ class MoreInfoFan extends LitElement {
                       slot="trigger"
                       .disabled=${this.stateObj.state === UNAVAILABLE}
                     >
-                      ${this._presetMode ||
-                      computeAttributeNameDisplay(
-                        this.hass.localize,
-                        this.stateObj,
-                        this.hass.entities,
-                        "preset_mode"
-                      )}
+                      ${this._presetMode
+                        ? computeAttributeValueDisplay(
+                            this.hass.localize,
+                            this.stateObj!,
+                            this.hass.locale,
+                            this.hass.entities,
+                            "preset_mode",
+                            this._presetMode
+                          )
+                        : computeAttributeNameDisplay(
+                            this.hass.localize,
+                            this.stateObj,
+                            this.hass.entities,
+                            "preset_mode"
+                          )}
                       <ha-svg-icon
                         slot="icon"
                         path=${mdiCreation}
diff --git a/src/dialogs/more-info/controls/more-info-light.ts b/src/dialogs/more-info/controls/more-info-light.ts
index b212498bf7..7889d66a3a 100644
--- a/src/dialogs/more-info/controls/more-info-light.ts
+++ b/src/dialogs/more-info/controls/more-info-light.ts
@@ -18,7 +18,10 @@ import { customElement, property, state } from "lit/decorators";
 import { classMap } from "lit/directives/class-map";
 import { fireEvent } from "../../../common/dom/fire_event";
 import { stopPropagation } from "../../../common/dom/stop_propagation";
-import { computeAttributeNameDisplay } from "../../../common/entity/compute_attribute_display";
+import {
+  computeAttributeNameDisplay,
+  computeAttributeValueDisplay,
+} from "../../../common/entity/compute_attribute_display";
 import { supportsFeature } from "../../../common/entity/supports-feature";
 import { blankBeforePercent } from "../../../common/translations/blank_before_percent";
 import "../../../components/ha-attributes";
@@ -236,13 +239,21 @@ class MoreInfoLight extends LitElement {
                   .disabled=${this.stateObj.state === UNAVAILABLE}
                 >
                   <ha-svg-icon slot="icon" path=${mdiCreation}></ha-svg-icon>
-                  ${this._effect ||
-                  computeAttributeNameDisplay(
-                    this.hass.localize,
-                    this.stateObj,
-                    this.hass.entities,
-                    "effect"
-                  )}
+                  ${this._effect
+                    ? computeAttributeValueDisplay(
+                        this.hass.localize,
+                        this.stateObj!,
+                        this.hass.locale,
+                        this.hass.entities,
+                        "effect",
+                        this._effect
+                      )
+                    : computeAttributeNameDisplay(
+                        this.hass.localize,
+                        this.stateObj,
+                        this.hass.entities,
+                        "effect"
+                      )}
                 </ha-outlined-button>
                 ${this.stateObj.attributes.effect_list.map(
                   (effect: string) => html`
@@ -250,7 +261,14 @@ class MoreInfoLight extends LitElement {
                       .value=${effect}
                       .activated=${this.stateObj!.attributes.effect === effect}
                     >
-                      ${effect}
+                      ${computeAttributeValueDisplay(
+                        this.hass.localize,
+                        this.stateObj!,
+                        this.hass.locale,
+                        this.hass.entities,
+                        "effect",
+                        effect
+                      )}
                     </ha-list-item>
                   `
                 )}