jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-23 17:26:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure 0 does not get formatted to empty string (#8971)

Browse Source
This commit is contained in:
Philip Allgaier 2021-04-23 09:29:03 +02:00 committed by GitHub
parent 3f21c87a3d
commit 899eab4e5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 51 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/string/format_number.ts
View File

@ -58,7 +58,7 @@ export const formatNumber = (
).format(Number(num));
}
}
return num ? num.toString() : "";
return num.toString();
};
/**

50
test-mocha/common/string/format_number.ts
View File

@ -15,6 +15,56 @@ describe("formatNumber", () => {
);
});
it("Test format 'none' (keep dot despite language 'de')", () => {
assert.strictEqual(
formatNumber(1.23, {
language: "de",
number_format: NumberFormat.none,
}),
"1.23"
);
});
it("Ensure zero is kept for format 'language'", () => {
assert.strictEqual(
formatNumber(0, {
language: "en",
number_format: NumberFormat.language,
}),
"0"
);
});
it("Ensure zero is kept for format 'none'", () => {
assert.strictEqual(
formatNumber(0, {
language: "en",
number_format: NumberFormat.none,
}),
"0"
);
});
it("Test empty string input for format 'none'", () => {
assert.strictEqual(
formatNumber("", {
language: "en",
number_format: NumberFormat.none,
}),
""
);
});
it("Test empty string input for format 'language'", () => {
assert.strictEqual(
formatNumber("", {
language: "en",
number_format: NumberFormat.language,
}),
"0"
);
});
it("Formats number with options", () => {
assert.strictEqual(
formatNumber(