From 97652bd2f6bfc6e18c25a58338b2161a0c843a74 Mon Sep 17 00:00:00 2001 From: Yosi Levy <37745463+yosilevy@users.noreply.github.com> Date: Fri, 26 Jan 2024 18:15:27 +0200 Subject: [PATCH] Various RTL fixes (#19495) * Various RTL fixes * Additional RTL * Additional fixes * Revert ha-dialog * Improve margin-title * Additional fixes * Additional fixes * Fix prettier * More fixes * Additional fixes * Fix prettier * Fix prettier again * Additional updates * Additional fixes * Final fixes (left only) --- hassio/src/addon-store/hassio-addon-store.ts | 2 ++ hassio/src/addon-view/info/hassio-addon-info.ts | 4 +++- hassio/src/backups/hassio-backups.ts | 4 ++++ hassio/src/components/hassio-card-content.ts | 4 ++++ hassio/src/components/supervisor-backup-content.ts | 4 ++++ hassio/src/components/supervisor-formfield-label.ts | 4 ++++ .../dialogs/backup/dialog-hassio-create-backup.ts | 3 +++ hassio/src/dialogs/network/dialog-hassio-network.ts | 2 ++ .../repositories/dialog-hassio-repositories.ts | 2 ++ hassio/src/ingress-view/hassio-ingress-view.ts | 2 +- src/auth/ha-auth-flow.ts | 2 ++ src/common/util/compute_rtl.ts | 4 ++++ src/components/ha-alert.ts | 1 - src/components/ha-area-filter.ts | 8 ++++---- src/components/ha-check-list-item.ts | 4 ++++ src/components/ha-expansion-panel.ts | 11 ++++++----- src/components/ha-header-bar.ts | 4 ++++ src/components/ha-label.ts | 2 ++ src/components/ha-multi-textfield.ts | 2 ++ src/components/ha-service-control.ts | 7 +++++++ src/components/ha-top-app-bar-fixed.ts | 4 ++++ src/components/ha-two-pane-top-app-bar-fixed.ts | 4 ++++ src/components/media-player/dialog-media-manage.ts | 4 ---- src/components/trace/hat-script-graph.ts | 2 ++ .../config-flow/previews/entity-preview-row.ts | 2 ++ src/dialogs/config-flow/step-flow-create-entry.ts | 2 ++ .../more-info/controls/more-info-datetime.ts | 2 ++ .../more-info/controls/more-info-input_datetime.ts | 2 ++ .../more-info/controls/more-info-media_player.ts | 2 ++ src/dialogs/more-info/controls/more-info-weather.ts | 7 +++++++ src/layouts/hass-subpage.ts | 2 +- src/layouts/hass-tabs-subpage.ts | 4 +++- src/panels/calendar/dialog-calendar-event-detail.ts | 2 +- src/panels/calendar/dialog-calendar-event-editor.ts | 4 +++- .../ha-config-application-credentials.ts | 2 ++ .../action/types/ha-automation-action-service.ts | 2 ++ .../types/ha-automation-trigger-conversation.ts | 2 ++ src/panels/config/cloud/account/cloud-tts-pref.ts | 4 ++++ .../device-detail/ha-device-entities-card.ts | 2 ++ .../config/devices/ha-config-devices-dashboard.ts | 2 ++ src/panels/config/entities/ha-config-entities.ts | 5 +++++ src/panels/config/helpers/forms/ha-counter-form.ts | 2 ++ .../config/helpers/forms/ha-input_select-form.ts | 4 ++++ .../config/integrations/dialog-add-integration.ts | 2 ++ .../integrations/ha-config-integration-page.ts | 4 ++++ .../config/integrations/ha-integration-card.ts | 2 ++ .../integration-panels/mqtt/mqtt-config-panel.ts | 2 ++ .../integration-panels/mqtt/mqtt-subscribe-card.ts | 2 ++ .../integration-panels/zha/zha-add-devices-page.ts | 2 ++ .../zwave_js/dialog-zwave_js-add-node.ts | 4 ++++ src/panels/config/logs/ha-config-logs.ts | 2 ++ src/panels/config/network/supervisor-network.ts | 2 ++ src/panels/config/users/dialog-user-detail.ts | 11 ++++++++++- .../voice-assistants/entity-voice-settings.ts | 6 ++++++ .../ha-config-voice-assistants-expose.ts | 2 ++ .../developer-tools/ha-panel-developer-tools.ts | 4 +++- .../service/developer-tools-service.ts | 2 ++ .../statistics/dialog-statistics-adjust-sum.ts | 4 ++-- src/panels/energy/ha-panel-energy.ts | 6 +++++- .../cards/energy/hui-energy-gas-graph-card.ts | 2 ++ .../cards/energy/hui-energy-solar-graph-card.ts | 2 ++ .../cards/energy/hui-energy-usage-graph-card.ts | 2 ++ .../cards/energy/hui-energy-water-graph-card.ts | 2 ++ src/panels/lovelace/cards/hui-alarm-panel-card.ts | 2 ++ src/panels/lovelace/cards/hui-area-card.ts | 2 ++ src/panels/lovelace/cards/hui-empty-state-card.ts | 2 ++ .../lovelace/cards/hui-picture-glance-card.ts | 2 ++ src/panels/lovelace/components/hui-buttons-base.ts | 6 ++++++ .../components/hui-energy-period-selector.ts | 8 ++++++++ .../lovelace/components/hui-generic-entity-row.ts | 6 ++++++ .../editor/card-editor/hui-dialog-edit-card.ts | 3 +++ .../lovelace/editor/hui-sub-element-editor.ts | 8 ++++---- .../lovelace/entity-rows/hui-weather-entity-row.ts | 4 ++++ src/panels/lovelace/hui-root.ts | 4 +++- src/panels/lovelace/special-rows/hui-button-row.ts | 4 ++++ src/panels/lovelace/special-rows/hui-cast-row.ts | 2 ++ src/panels/lovelace/special-rows/hui-section-row.ts | 4 ++++ src/panels/lovelace/special-rows/hui-text-row.ts | 4 +++- src/panels/lovelace/special-rows/hui-weblink-row.ts | 2 ++ src/panels/mailbox/ha-panel-mailbox.ts | 2 ++ src/panels/todo/dialog-todo-item-editor.ts | 2 ++ src/resources/ha-style.ts | 2 ++ src/resources/styles.ts | 2 ++ .../climate/ha-state-control-climate-temperature.ts | 13 ++++++++----- src/state-summary/state-card-climate.ts | 4 +++- src/state-summary/state-card-humidifier.ts | 4 +++- src/state-summary/state-card-input_text.ts | 2 ++ src/state-summary/state-card-media_player.ts | 4 +++- src/state-summary/state-card-timer.ts | 4 +++- src/state-summary/state-card-update.ts | 1 - src/state-summary/state-card-water_heater.ts | 4 +++- 91 files changed, 274 insertions(+), 42 deletions(-) diff --git a/hassio/src/addon-store/hassio-addon-store.ts b/hassio/src/addon-store/hassio-addon-store.ts index b3ef1e2c6e..76f0639e49 100644 --- a/hassio/src/addon-store/hassio-addon-store.ts +++ b/hassio/src/addon-store/hassio-addon-store.ts @@ -243,6 +243,8 @@ export class HassioAddonStore extends LitElement { } .advanced a { margin-left: 0.5em; + margin-inline-start: 0.5em; + margin-inline-end: initial; color: var(--primary-color); } `; diff --git a/hassio/src/addon-view/info/hassio-addon-info.ts b/hassio/src/addon-view/info/hassio-addon-info.ts index 11d257f722..8b183fc51d 100644 --- a/hassio/src/addon-view/info/hassio-addon-info.ts +++ b/hassio/src/addon-view/info/hassio-addon-info.ts @@ -1188,11 +1188,13 @@ class HassioAddonInfo extends LitElement { } .addon-header { padding-left: 8px; + padding-inline-start: 8px; + padding-inline-end: initial; font-size: 24px; color: var(--ha-card-header-color, --primary-text-color); } .addon-version { - float: right; + float: var(--float-end); font-size: 15px; vertical-align: middle; } diff --git a/hassio/src/backups/hassio-backups.ts b/hassio/src/backups/hassio-backups.ts index 7d0819fc83..64c735d977 100644 --- a/hassio/src/backups/hassio-backups.ts +++ b/hassio/src/backups/hassio-backups.ts @@ -395,6 +395,8 @@ export class HassioBackups extends LitElement { .selected-txt { font-weight: bold; padding-left: 16px; + padding-inline-start: 16px; + padding-inline-end: initial; color: var(--primary-text-color); } .table-header .selected-txt { @@ -405,6 +407,8 @@ export class HassioBackups extends LitElement { } .header-toolbar .header-btns { margin-right: -12px; + margin-inline-end: -12px; + margin-inline-start: initial; } .header-btns > mwc-button, .header-btns > ha-icon-button { diff --git a/hassio/src/components/hassio-card-content.ts b/hassio/src/components/hassio-card-content.ts index d1f804ed60..3222525dd5 100644 --- a/hassio/src/components/hassio-card-content.ts +++ b/hassio/src/components/hassio-card-content.ts @@ -60,6 +60,10 @@ class HassioCardContent extends LitElement { static get styles(): CSSResultGroup { return css` + :host { + direction: ltr; + } + ha-svg-icon { margin-right: 24px; margin-left: 8px; diff --git a/hassio/src/components/supervisor-backup-content.ts b/hassio/src/components/supervisor-backup-content.ts index 0c76daba83..ddbde0f4f3 100644 --- a/hassio/src/components/supervisor-backup-content.ts +++ b/hassio/src/components/supervisor-backup-content.ts @@ -316,6 +316,8 @@ export class SupervisorBackupContent extends LitElement { display: flex; flex-direction: column; margin-left: 30px; + margin-inline-start: 30px; + margin-inline-end: initial; } ha-formfield.password { display: block; @@ -324,6 +326,8 @@ export class SupervisorBackupContent extends LitElement { .backup-types { display: flex; margin-left: -13px; + margin-inline-start: -13px; + margin-inline-end: initial; } .sub-header { margin-top: 8px; diff --git a/hassio/src/components/supervisor-formfield-label.ts b/hassio/src/components/supervisor-formfield-label.ts index c6986c714b..8f740185f6 100644 --- a/hassio/src/components/supervisor-formfield-label.ts +++ b/hassio/src/components/supervisor-formfield-label.ts @@ -37,6 +37,8 @@ class SupervisorFormfieldLabel extends LitElement { } .label { margin-right: 4px; + margin-inline-end: 4px; + margin-inline-start: initial; } .version { color: var(--secondary-text-color); @@ -45,6 +47,8 @@ class SupervisorFormfieldLabel extends LitElement { max-height: 22px; max-width: 22px; margin-right: 8px; + margin-inline-end: 8px; + margin-inline-start: initial; } `; } diff --git a/hassio/src/dialogs/backup/dialog-hassio-create-backup.ts b/hassio/src/dialogs/backup/dialog-hassio-create-backup.ts index c85b360df5..b009043079 100644 --- a/hassio/src/dialogs/backup/dialog-hassio-create-backup.ts +++ b/hassio/src/dialogs/backup/dialog-hassio-create-backup.ts @@ -138,6 +138,9 @@ class HassioCreateBackupDialog extends LitElement { haStyle, haStyleDialog, css` + :host { + direction: var(--direction); + } ha-circular-progress { display: block; text-align: center; diff --git a/hassio/src/dialogs/network/dialog-hassio-network.ts b/hassio/src/dialogs/network/dialog-hassio-network.ts index b36b734a08..66b381e0c0 100644 --- a/hassio/src/dialogs/network/dialog-hassio-network.ts +++ b/hassio/src/dialogs/network/dialog-hassio-network.ts @@ -597,6 +597,8 @@ export class DialogHassioNetwork mwc-button.scan { margin-left: 8px; + margin-inline-start: 8px; + margin-inline-end: initial; } .container { diff --git a/hassio/src/dialogs/repositories/dialog-hassio-repositories.ts b/hassio/src/dialogs/repositories/dialog-hassio-repositories.ts index 1399e552df..74ce8d5a6a 100644 --- a/hassio/src/dialogs/repositories/dialog-hassio-repositories.ts +++ b/hassio/src/dialogs/repositories/dialog-hassio-repositories.ts @@ -195,6 +195,8 @@ class HassioRepositoriesDialog extends LitElement { } mwc-button { margin-left: 8px; + margin-inline-start: 8px; + margin-inline-end: initial; } ha-circular-progress { display: block; diff --git a/hassio/src/ingress-view/hassio-ingress-view.ts b/hassio/src/ingress-view/hassio-ingress-view.ts index 45fd998b4b..1dd895bdfe 100644 --- a/hassio/src/ingress-view/hassio-ingress-view.ts +++ b/hassio/src/ingress-view/hassio-ingress-view.ts @@ -360,7 +360,7 @@ class HassioIngressView extends LitElement { } .main-title { - margin: 0 0 0 24px; + margin: var(--margin-title); line-height: 20px; flex-grow: 1; } diff --git a/src/auth/ha-auth-flow.ts b/src/auth/ha-auth-flow.ts index 66a93c021c..db5b233073 100644 --- a/src/auth/ha-auth-flow.ts +++ b/src/auth/ha-auth-flow.ts @@ -93,6 +93,8 @@ export class HaAuthFlow extends LitElement {