From 984570c55b9ce24ee5c1ef312158733479ea7905 Mon Sep 17 00:00:00 2001 From: Zack Arnett Date: Sat, 3 Nov 2018 14:15:51 -0400 Subject: [PATCH 1/5] Revert RTL PR (#1975) * Revert RTL PR * Missed this change --- src/layouts/home-assistant-main.js | 17 +---------------- src/translations/translationMetadata.json | 3 +-- src/types.ts | 1 - 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/src/layouts/home-assistant-main.js b/src/layouts/home-assistant-main.js index 2dff9ed87b..aed68ad85c 100644 --- a/src/layouts/home-assistant-main.js +++ b/src/layouts/home-assistant-main.js @@ -27,9 +27,6 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) { /* remove the grey tap highlights in iOS on the fullscreen touch targets */ -webkit-tap-highlight-color: rgba(0,0,0,0); } - :host([rtl]) { - direction: rtl; - } iron-pages, ha-sidebar { /* allow a light tap highlight on the actual interface elements */ -webkit-tap-highlight-color: rgba(0,0,0,0.1); @@ -45,7 +42,7 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) { - + @@ -72,11 +69,6 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) { type: Boolean, computed: "computeDockedSidebar(hass)", }, - rtl: { - type: Boolean, - reflectToAttribute: true, - computed: "computeRTL(hass)", - }, }; } @@ -131,13 +123,6 @@ class HomeAssistantMain extends NavigateMixin(EventsMixin(PolymerElement)) { return hass.dockedSidebar; } - computeRTL(hass) { - return ( - hass.translationMetadata.translations[hass.selectedLanguage].isRTL || - false - ); - } - _computeDisableSwipe(hass) { return NON_SWIPABLE_PANELS.indexOf(hass.panelUrl) !== -1; } diff --git a/src/translations/translationMetadata.json b/src/translations/translationMetadata.json index 3a31673c25..faaceac74c 100644 --- a/src/translations/translationMetadata.json +++ b/src/translations/translationMetadata.json @@ -51,8 +51,7 @@ "nativeName": "Schwiizerdütsch" }, "he": { - "nativeName": "עברית", - "isRTL": true + "nativeName": "עברית" }, "hi": { "nativeName": "हिन्दी" diff --git a/src/types.ts b/src/types.ts index 0699af1e67..6cc016d2ee 100644 --- a/src/types.ts +++ b/src/types.ts @@ -44,7 +44,6 @@ export interface Panel { export interface Translation { nativeName: string; - isRTL: boolean; fingerprints: { [fragment: string]: string }; } From e1c90d74e31111d95c0e15c6f83c1f9fafde9dc7 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Sat, 3 Nov 2018 19:17:48 +0100 Subject: [PATCH 2/5] Bumped version to 20181103.1 --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index be0ad87a31..277d3fac1d 100644 --- a/setup.py +++ b/setup.py @@ -2,7 +2,7 @@ from setuptools import setup, find_packages setup( name="home-assistant-frontend", - version="20181103.0", + version="20181103.1", description="The Home Assistant frontend", url="https://github.com/home-assistant/home-assistant-polymer", author="The Home Assistant Authors", From 849d7d2d957e5c33ff477218317a7739014047a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Lov=C3=A9n?= Date: Tue, 6 Nov 2018 12:39:00 +0100 Subject: [PATCH 3/5] Make conditional not take up space in stacks when hidden (#1999) * Make conditional not take up space in stacks when hidden * Update hui-conditional-card.ts --- src/panels/lovelace/cards/hui-conditional-card.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/panels/lovelace/cards/hui-conditional-card.ts b/src/panels/lovelace/cards/hui-conditional-card.ts index 3ad239be4f..067848eb67 100644 --- a/src/panels/lovelace/cards/hui-conditional-card.ts +++ b/src/panels/lovelace/cards/hui-conditional-card.ts @@ -67,6 +67,8 @@ class HuiConditionalCard extends HTMLElement implements LovelaceCard { } else if (this._card.parentElement) { this.removeChild(this._card); } + // This will hide the complete card so it won't get styled by parent + this.style.setProperty("display", visible ? "" : "none"); } public getCardSize() { From 23163b30952faf560d3364d68ae586ac838ea132 Mon Sep 17 00:00:00 2001 From: Ian Richardson Date: Wed, 7 Nov 2018 02:42:46 -0600 Subject: [PATCH 4/5] Fix iframe aspect_ratio (#2004) --- src/panels/lovelace/cards/hui-iframe-card.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/panels/lovelace/cards/hui-iframe-card.ts b/src/panels/lovelace/cards/hui-iframe-card.ts index 13827cc89e..a8089344d7 100644 --- a/src/panels/lovelace/cards/hui-iframe-card.ts +++ b/src/panels/lovelace/cards/hui-iframe-card.ts @@ -4,6 +4,7 @@ import "../../../components/ha-card"; import { LovelaceCard, LovelaceConfig } from "../types"; import { TemplateResult } from "lit-html"; +import { styleMap } from "lit-html/directives/styleMap"; interface Config extends LovelaceConfig { aspect_ratio?: string; @@ -37,10 +38,16 @@ export class HuiIframeCard extends LitElement implements LovelaceCard { return html``; } + const aspectRatio = this._config.aspect_ratio || "50%"; + return html` ${this.renderStyle()} -
+
From b04ab6faa183a681fc74e599cb5dd2f6793c3a2d Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Wed, 7 Nov 2018 10:11:47 +0100 Subject: [PATCH 5/5] Bumped version to 20181103.2 --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 277d3fac1d..e50eff8890 100644 --- a/setup.py +++ b/setup.py @@ -2,7 +2,7 @@ from setuptools import setup, find_packages setup( name="home-assistant-frontend", - version="20181103.1", + version="20181103.2", description="The Home Assistant frontend", url="https://github.com/home-assistant/home-assistant-polymer", author="The Home Assistant Authors",