From 28d3f445f674d421b36a8cd6fc4c56f6c68ee2e2 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Wed, 23 Jan 2019 15:51:56 -0800 Subject: [PATCH 1/3] Align theme color --- demo/public/index.html | 8 ++++---- demo/public/manifest.json | 2 +- src/html/index.html.template | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/demo/public/index.html b/demo/public/index.html index 84b16d37c0..a685e87125 100644 --- a/demo/public/index.html +++ b/demo/public/index.html @@ -4,7 +4,7 @@ - + - + - + @@ -91,7 +91,7 @@ display: block; content: ""; height: 112px; - background-color: #3fbbf4; + background-color: #03a9f4; } diff --git a/demo/public/manifest.json b/demo/public/manifest.json index a38462f2e5..ce52141bda 100644 --- a/demo/public/manifest.json +++ b/demo/public/manifest.json @@ -27,7 +27,7 @@ ], "lang": "en-US", "name": "Home Assistant Demo", - "short_name": "Assistant Demo", + "short_name": "Demo", "start_url": "/?homescreen=1", "theme_color": "#03A9F4" } diff --git a/src/html/index.html.template b/src/html/index.html.template index c6f1a653af..fc0e515764 100644 --- a/src/html/index.html.template +++ b/src/html/index.html.template @@ -8,13 +8,13 @@ Home Assistant - + - + From 37b21546389eedb54dab21060fbd7b2e661565cc Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Wed, 23 Jan 2019 15:52:07 -0800 Subject: [PATCH 2/3] Allow demo config to be tested from other device on network --- demo/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demo/webpack.config.js b/demo/webpack.config.js index 598e50cdbc..f5a3fd1d2d 100644 --- a/demo/webpack.config.js +++ b/demo/webpack.config.js @@ -8,7 +8,7 @@ const { babelLoaderConfig } = require("../config/babel.js"); const isProd = process.env.NODE_ENV === "production"; const chunkFilename = isProd ? "chunk.[chunkhash].js" : "[name].chunk.js"; const buildPath = path.resolve(__dirname, "dist"); -const publicPath = isProd ? "./" : "http://localhost:8080/"; +const publicPath = "./"; const latestBuild = false; From e3d32c9dd053694a1b7ad2071eff44c8d561928d Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Wed, 23 Jan 2019 16:05:36 -0800 Subject: [PATCH 3/3] Dont' jump media player on initial load --- src/cards/ha-media_player-card.js | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/cards/ha-media_player-card.js b/src/cards/ha-media_player-card.js index 2f413fd550..6bbda8eab6 100644 --- a/src/cards/ha-media_player-card.js +++ b/src/cards/ha-media_player-card.js @@ -158,7 +158,9 @@ class HaMediaPlayerCard extends LocalizeMixin(EventsMixin(PolymerElement)) { } -
+
@@ -228,6 +230,10 @@ class HaMediaPlayerCard extends LocalizeMixin(EventsMixin(PolymerElement)) { computed: "computePlaybackControlIcon(playerObj)", }, playbackPosition: Number, + _coverShowing: { + type: Boolean, + value: false, + }, _coverLoadError: { type: Boolean, value: false, @@ -269,11 +275,13 @@ class HaMediaPlayerCard extends LocalizeMixin(EventsMixin(PolymerElement)) { type: "media_player_thumbnail", entity_id: playerObj.stateObj.entity_id, }); + this._coverShowing = true; this._coverLoadError = false; this.$.cover.style.backgroundImage = `url(data:${contentType};base64,${content})`; } catch (err) { - this.$.cover.style.backgroundImage = ""; + this._coverShowing = false; this._coverLoadError = true; + this.$.cover.style.backgroundImage = ""; } } @@ -281,20 +289,20 @@ class HaMediaPlayerCard extends LocalizeMixin(EventsMixin(PolymerElement)) { this.playbackPosition = this.playerObj.currentProgress; } - computeBannerClasses(playerObj, coverLoadError) { + computeBannerClasses(playerObj, coverShowing, coverLoadError) { var cls = "banner"; if (playerObj.isOff || playerObj.isIdle) { cls += " is-off no-cover"; } else if ( !playerObj.stateObj.attributes.entity_picture || - coverLoadError + coverLoadError || + !coverShowing ) { cls += " no-cover"; } else if (playerObj.stateObj.attributes.media_content_type === "music") { cls += " content-type-music"; } - return cls; }