From a3f680d80cd6696d462a7bc56757410887581815 Mon Sep 17 00:00:00 2001 From: Tomasz Date: Mon, 31 Aug 2020 14:59:12 +0200 Subject: [PATCH] Fix render modifiers - public to protected (#6753) --- hassio/src/components/hassio-ansi-to-html.ts | 2 +- hassio/src/system/hassio-host-info.ts | 22 ++++++++--------- hassio/src/system/hassio-supervisor-info.ts | 16 ++++++------- hassio/src/system/hassio-supervisor-log.ts | 2 +- hassio/src/system/hassio-system.ts | 4 ++-- src/components/ha-circular-progress.ts | 24 +++++++++---------- .../types/ha-automation-action-condition.ts | 2 +- .../types/ha-automation-action-delay.ts | 2 +- .../ha-automation-condition-numeric_state.ts | 4 ++-- .../types/ha-automation-trigger-event.ts | 2 +- .../ha-automation-trigger-homeassistant.ts | 2 +- .../ha-automation-trigger-numeric_state.ts | 4 ++-- src/panels/lovelace/hui-editor.ts | 12 +++++----- 13 files changed, 47 insertions(+), 51 deletions(-) diff --git a/hassio/src/components/hassio-ansi-to-html.ts b/hassio/src/components/hassio-ansi-to-html.ts index b553367b8a..b957b172b4 100644 --- a/hassio/src/components/hassio-ansi-to-html.ts +++ b/hassio/src/components/hassio-ansi-to-html.ts @@ -21,7 +21,7 @@ interface State { class HassioAnsiToHtml extends LitElement { @property() public content!: string; - public render(): TemplateResult | void { + protected render(): TemplateResult | void { return html`${this._parseTextToColoredPre(this.content)}`; } diff --git a/hassio/src/system/hassio-host-info.ts b/hassio/src/system/hassio-host-info.ts index 38ea35fa21..2f238a8c00 100644 --- a/hassio/src/system/hassio-host-info.ts +++ b/hassio/src/system/hassio-host-info.ts @@ -1,9 +1,8 @@ import "@material/mwc-button"; -import "@material/mwc-list/mwc-list-item"; import { ActionDetail } from "@material/mwc-list/mwc-list-foundation"; +import "@material/mwc-list/mwc-list-item"; import { mdiDotsVertical } from "@mdi/js"; import { safeDump } from "js-yaml"; -import memoizeOne from "memoize-one"; import { css, CSSResult, @@ -14,7 +13,11 @@ import { property, TemplateResult, } from "lit-element"; - +import memoizeOne from "memoize-one"; +import "../../../src/components/ha-button-menu"; +import "../../../src/components/ha-card"; +import "../../../src/components/ha-settings-row"; +import { fetchHassioHardwareInfo } from "../../../src/data/hassio/hardware"; import { changeHostOptions, configSyncOS, @@ -25,26 +28,21 @@ import { shutdownHost, updateOS, } from "../../../src/data/hassio/host"; -import { fetchHassioHardwareInfo } from "../../../src/data/hassio/hardware"; import { fetchNetworkInfo, NetworkInfo, } from "../../../src/data/hassio/network"; import { HassioInfo } from "../../../src/data/hassio/supervisor"; -import { hassioStyle } from "../resources/hassio-style"; -import { haStyle } from "../../../src/resources/styles"; -import { HomeAssistant } from "../../../src/types"; import { showAlertDialog, showConfirmationDialog, showPromptDialog, } from "../../../src/dialogs/generic/show-dialog-box"; +import { haStyle } from "../../../src/resources/styles"; +import { HomeAssistant } from "../../../src/types"; import { showHassioMarkdownDialog } from "../dialogs/markdown/show-dialog-hassio-markdown"; import { showNetworkDialog } from "../dialogs/network/show-dialog-network"; - -import "../../../src/components/ha-button-menu"; -import "../../../src/components/ha-card"; -import "../../../src/components/ha-settings-row"; +import { hassioStyle } from "../resources/hassio-style"; @customElement("hassio-host-info") class HassioHostInfo extends LitElement { @@ -58,7 +56,7 @@ class HassioHostInfo extends LitElement { @internalProperty() public _networkInfo?: NetworkInfo; - public render(): TemplateResult | void { + protected render(): TemplateResult | void { const primaryIpAddress = this.hostInfo.features.includes("network") ? this._primaryIpAddress(this._networkInfo!) : ""; diff --git a/hassio/src/system/hassio-supervisor-info.ts b/hassio/src/system/hassio-supervisor-info.ts index 6213c829ba..560a04e534 100644 --- a/hassio/src/system/hassio-supervisor-info.ts +++ b/hassio/src/system/hassio-supervisor-info.ts @@ -8,11 +8,10 @@ import { property, TemplateResult, } from "lit-element"; - +import "../../../src/components/ha-card"; +import "../../../src/components/ha-settings-row"; +import "../../../src/components/ha-switch"; import { HassioHostInfo as HassioHostInfoType } from "../../../src/data/hassio/host"; -import { hassioStyle } from "../resources/hassio-style"; -import { haStyle } from "../../../src/resources/styles"; -import { HomeAssistant } from "../../../src/types"; import { HassioSupervisorInfo as HassioSupervisorInfoType, reloadSupervisor, @@ -24,10 +23,9 @@ import { showAlertDialog, showConfirmationDialog, } from "../../../src/dialogs/generic/show-dialog-box"; - -import "../../../src/components/ha-card"; -import "../../../src/components/ha-settings-row"; -import "../../../src/components/ha-switch"; +import { haStyle } from "../../../src/resources/styles"; +import { HomeAssistant } from "../../../src/types"; +import { hassioStyle } from "../resources/hassio-style"; @customElement("hassio-supervisor-info") class HassioSupervisorInfo extends LitElement { @@ -37,7 +35,7 @@ class HassioSupervisorInfo extends LitElement { @property() public hostInfo!: HassioHostInfoType; - public render(): TemplateResult | void { + protected render(): TemplateResult | void { return html`
diff --git a/hassio/src/system/hassio-supervisor-log.ts b/hassio/src/system/hassio-supervisor-log.ts index de2c08cda5..68fba0f1ab 100644 --- a/hassio/src/system/hassio-supervisor-log.ts +++ b/hassio/src/system/hassio-supervisor-log.ts @@ -69,7 +69,7 @@ class HassioSupervisorLog extends LitElement { await this._loadData(); } - public render(): TemplateResult | void { + protected render(): TemplateResult | void { return html` ${this._error ? html`
${this._error}
` : ""} diff --git a/hassio/src/system/hassio-system.ts b/hassio/src/system/hassio-system.ts index ad91a42825..f2ffc2cc62 100644 --- a/hassio/src/system/hassio-system.ts +++ b/hassio/src/system/hassio-system.ts @@ -12,8 +12,8 @@ import { HassioHostInfo, } from "../../../src/data/hassio/host"; import { - HassioSupervisorInfo, HassioInfo, + HassioSupervisorInfo, } from "../../../src/data/hassio/supervisor"; import "../../../src/layouts/hass-tabs-subpage"; import { haStyle } from "../../../src/resources/styles"; @@ -40,7 +40,7 @@ class HassioSystem extends LitElement { @property({ attribute: false }) public hassOsInfo!: HassioHassOSInfo; - public render(): TemplateResult | void { + protected render(): TemplateResult | void { return html` diff --git a/src/panels/config/automation/trigger/types/ha-automation-trigger-numeric_state.ts b/src/panels/config/automation/trigger/types/ha-automation-trigger-numeric_state.ts index 6d10f83c2d..068dbd6856 100644 --- a/src/panels/config/automation/trigger/types/ha-automation-trigger-numeric_state.ts +++ b/src/panels/config/automation/trigger/types/ha-automation-trigger-numeric_state.ts @@ -1,8 +1,8 @@ import "@polymer/paper-input/paper-input"; +import "@polymer/paper-input/paper-textarea"; import { customElement, html, LitElement, property } from "lit-element"; import { fireEvent } from "../../../../../common/dom/fire_event"; import "../../../../../components/entity/ha-entity-picker"; -import "@polymer/paper-input/paper-textarea"; import { ForDict, NumericStateTrigger } from "../../../../../data/automation"; import { HomeAssistant } from "../../../../../types"; import { handleChangeEvent } from "../ha-automation-trigger-row"; @@ -19,7 +19,7 @@ export default class HaNumericStateTrigger extends LitElement { }; } - public render() { + protected render() { const { value_template, entity_id, below, above } = this.trigger; let trgFor = this.trigger.for; diff --git a/src/panels/lovelace/hui-editor.ts b/src/panels/lovelace/hui-editor.ts index 998b08af3b..84a9f86fe1 100644 --- a/src/panels/lovelace/hui-editor.ts +++ b/src/panels/lovelace/hui-editor.ts @@ -1,34 +1,34 @@ import "@material/mwc-button"; -import "../../layouts/ha-app-layout"; import "@polymer/app-layout/app-header/app-header"; import "@polymer/app-layout/app-toolbar/app-toolbar"; -import "../../components/ha-icon-button"; -import "../../components/ha-circular-progress"; import { safeDump, safeLoad } from "js-yaml"; import { css, CSSResult, customElement, html, + internalProperty, LitElement, property, - internalProperty, TemplateResult, } from "lit-element"; import { classMap } from "lit-html/directives/class-map"; +import { array, assert, object, optional, string, type } from "superstruct"; import { computeRTL } from "../../common/util/compute_rtl"; +import "../../components/ha-circular-progress"; import "../../components/ha-code-editor"; import type { HaCodeEditor } from "../../components/ha-code-editor"; import "../../components/ha-icon"; +import "../../components/ha-icon-button"; import type { LovelaceConfig } from "../../data/lovelace"; import { showAlertDialog, showConfirmationDialog, } from "../../dialogs/generic/show-dialog-box"; +import "../../layouts/ha-app-layout"; import { haStyle } from "../../resources/styles"; import type { HomeAssistant } from "../../types"; import type { Lovelace } from "./types"; -import { optional, array, string, object, type, assert } from "superstruct"; const lovelaceStruct = type({ title: optional(string()), @@ -49,7 +49,7 @@ class LovelaceFullConfigEditor extends LitElement { private _generation = 1; - public render(): TemplateResult | void { + protected render(): TemplateResult | void { return html`