From b1f5ff26d92b530ff1a56e67c0d5be76b8420db4 Mon Sep 17 00:00:00 2001 From: karwosts <32912880+karwosts@users.noreply.github.com> Date: Fri, 2 Jun 2023 02:26:07 -0700 Subject: [PATCH] Fix device selector when picking devices with no entities (#16734) --- src/components/ha-selector/ha-selector-device.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/components/ha-selector/ha-selector-device.ts b/src/components/ha-selector/ha-selector-device.ts index 741a8712bd..0af1b288a1 100644 --- a/src/components/ha-selector/ha-selector-device.ts +++ b/src/components/ha-selector/ha-selector-device.ts @@ -77,7 +77,9 @@ export class HaDeviceSelector extends LitElement { .label=${this.label} .helper=${this.helper} .deviceFilter=${this._filterDevices} - .entityFilter=${this._filterEntities} + .entityFilter=${this.selector.device?.entity + ? this._filterEntities + : undefined} .disabled=${this.disabled} .required=${this.required} allow-custom-entity @@ -92,7 +94,9 @@ export class HaDeviceSelector extends LitElement { .value=${this.value} .helper=${this.helper} .deviceFilter=${this._filterDevices} - .entityFilter=${this._filterEntities} + .entityFilter=${this.selector.device?.entity + ? this._filterEntities + : undefined} .disabled=${this.disabled} .required=${this.required} > @@ -115,14 +119,10 @@ export class HaDeviceSelector extends LitElement { ); }; - private _filterEntities = (entity: HassEntity): boolean => { - if (!this.selector.device?.entity) { - return true; - } - return ensureArray(this.selector.device.entity).some((filter) => + private _filterEntities = (entity: HassEntity): boolean => + ensureArray(this.selector.device!.entity).some((filter) => filterSelectorEntities(filter, entity, this._entitySources) ); - }; } declare global {