From baeda622dea762a5b6b3f165c588e2eed4229e16 Mon Sep 17 00:00:00 2001
From: Bram Kragten <mail@bramkragten.nl>
Date: Fri, 7 Dec 2018 14:14:29 +0100
Subject: [PATCH] Save columns as string (#2214)

* save columns as string

* set type to number to convert to number before save
---
 .../config-elements/hui-glance-card-editor.ts      | 14 +++++++-------
 src/panels/lovelace/editor/types.ts                |  2 ++
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/panels/lovelace/editor/config-elements/hui-glance-card-editor.ts b/src/panels/lovelace/editor/config-elements/hui-glance-card-editor.ts
index 672b8b6775..b93bc827d2 100644
--- a/src/panels/lovelace/editor/config-elements/hui-glance-card-editor.ts
+++ b/src/panels/lovelace/editor/config-elements/hui-glance-card-editor.ts
@@ -93,6 +93,7 @@ export class HuiGlanceCardEditor extends hassLocalizeLitMixin(LitElement)
           ></hui-theme-select-editor>
           <paper-input
             label="Columns"
+            type="number"
             value="${this._columns}"
             .configValue="${"columns"}"
             @value-changed="${this._valueChanged}"
@@ -127,22 +128,21 @@ export class HuiGlanceCardEditor extends hassLocalizeLitMixin(LitElement)
     }
     const target = ev.target! as EditorTarget;
 
-    if (
-      (target.configValue! === "title" && target.value === this._title) ||
-      (target.configValue! === "theme" && target.value === this._theme) ||
-      (target.configValue! === "columns" && target.value === this._columns)
-    ) {
+    if (this[`_${target.configValue}`] === target.value) {
       return;
     }
-
     if (ev.detail && ev.detail.entities) {
       this._config.entities = ev.detail.entities;
       this._configEntities = processEditorEntities(this._config.entities);
     } else if (target.configValue) {
+      let value: any = target.value;
+      if (target.type === "number") {
+        value = Number(value);
+      }
       this._config = {
         ...this._config,
         [target.configValue!]:
-          target.checked !== undefined ? target.checked : target.value,
+          target.checked !== undefined ? target.checked : value,
       };
     }
     fireEvent(this, "config-changed", { config: this._config });
diff --git a/src/panels/lovelace/editor/types.ts b/src/panels/lovelace/editor/types.ts
index fe76d20ece..93f66220c6 100644
--- a/src/panels/lovelace/editor/types.ts
+++ b/src/panels/lovelace/editor/types.ts
@@ -1,5 +1,6 @@
 import { LovelaceCardConfig, LovelaceViewConfig } from "../../../data/lovelace";
 import { EntityConfig } from "../entity-rows/types";
+import { InputType } from "zlib";
 
 export interface YamlChangedEvent extends Event {
   detail: {
@@ -41,6 +42,7 @@ export interface EditorTarget extends EventTarget {
   index?: number;
   checked?: boolean;
   configValue?: string;
+  type?: InputType;
 }
 
 export interface CardPickTarget extends EventTarget {