jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-25 18:26:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix non-hass shouldUpdate regressions (#18810)

Browse Source
This commit is contained in:
karwosts 2023-11-29 06:28:38 -08:00 committed by GitHub
parent 4ec11c7cf6
commit bf24740c7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/panels/lovelace/cards/hui-history-graph-card.ts
View File

@ -151,10 +151,11 @@ export class HuiHistoryGraphCard extends LitElement implements LovelaceCard {
} }
protected shouldUpdate(changedProps: PropertyValues): boolean { protected shouldUpdate(changedProps: PropertyValues): boolean {
if (changedProps.has("_stateHistory")) { return (
return true; hasConfigOrEntitiesChanged(this, changedProps) ||
} changedProps.size > 1 ||
return hasConfigOrEntitiesChanged(this, changedProps); !changedProps.has("hass")
);
} }
protected updated(changedProps: PropertyValues) { protected updated(changedProps: PropertyValues) {

6
src/panels/lovelace/cards/hui-media-control-card.ts
View File

@ -330,7 +330,11 @@ export class HuiMediaControlCard extends LitElement implements LovelaceCard {
} }
protected shouldUpdate(changedProps: PropertyValues): boolean { protected shouldUpdate(changedProps: PropertyValues): boolean {
return hasConfigOrEntityChanged(this, changedProps); return (
hasConfigOrEntityChanged(this, changedProps) ||
changedProps.size > 1 ||
!changedProps.has("hass")
);
} }
protected firstUpdated(): void { protected firstUpdated(): void {

9
src/panels/lovelace/cards/hui-statistics-graph-card.ts
View File

@ -129,10 +129,11 @@ export class HuiStatisticsGraphCard extends LitElement implements LovelaceCard {
} }
protected shouldUpdate(changedProps: PropertyValues): boolean { protected shouldUpdate(changedProps: PropertyValues): boolean {
if (changedProps.has("_statistics")) { return (
return true; hasConfigOrEntitiesChanged(this, changedProps) ||
} changedProps.size > 1 ||
return hasConfigOrEntitiesChanged(this, changedProps); !changedProps.has("hass")
);
} }
public willUpdate(changedProps: PropertyValues) { public willUpdate(changedProps: PropertyValues) {

3
src/panels/lovelace/cards/hui-weather-forecast-card.ts
View File

@ -155,7 +155,8 @@ class HuiWeatherForecastCard extends LitElement implements LovelaceCard {
protected shouldUpdate(changedProps: PropertyValues): boolean { protected shouldUpdate(changedProps: PropertyValues): boolean {
return ( return (
hasConfigOrEntityChanged(this, changedProps) || hasConfigOrEntityChanged(this, changedProps) ||
changedProps.has("forecastEvent") changedProps.size > 1 ||
!changedProps.has("hass")
); );
} }

6
src/panels/lovelace/entity-rows/hui-media-player-entity-row.ts
View File

@ -82,7 +82,11 @@ class HuiMediaPlayerEntityRow extends LitElement implements LovelaceRow {
} }
protected shouldUpdate(changedProps: PropertyValues): boolean { protected shouldUpdate(changedProps: PropertyValues): boolean {
return hasConfigOrEntityChanged(this, changedProps); return (
hasConfigOrEntityChanged(this, changedProps) ||
changedProps.size > 1 ||
!changedProps.has("hass")
);
} }
protected render() { protected render() {

6
src/panels/lovelace/entity-rows/hui-weather-entity-row.ts
View File

@ -90,7 +90,11 @@ class HuiWeatherEntityRow extends LitElement implements LovelaceRow {
} }
protected shouldUpdate(changedProps: PropertyValues): boolean { protected shouldUpdate(changedProps: PropertyValues): boolean {
return hasConfigOrEntityChanged(this, changedProps); return (
hasConfigOrEntityChanged(this, changedProps) ||
changedProps.size > 1 ||
!changedProps.has("hass")
);
} }
protected updated(changedProps: PropertyValues): void { protected updated(changedProps: PropertyValues): void {