From bf912f7bd396e3b1286269738adae9625fe5158b Mon Sep 17 00:00:00 2001 From: Steve Repsher Date: Mon, 21 Aug 2023 06:57:38 -0400 Subject: [PATCH] Add missing super calls to disconnectedCallback (#17641) --- src/components/media-player/ha-media-player-browse.ts | 1 + src/panels/config/helpers/forms/ha-schedule-form.ts | 1 + src/panels/developer-tools/template/developer-tools-template.ts | 1 + src/panels/lovelace/cards/hui-calendar-card.ts | 1 + src/panels/lovelace/cards/hui-markdown-card.ts | 1 + src/panels/lovelace/cards/hui-media-control-card.ts | 1 + src/panels/lovelace/cards/hui-weather-forecast-card.ts | 1 + src/panels/lovelace/components/hui-entity-editor.ts | 1 + .../editor/config-elements/hui-tile-card-features-editor.ts | 1 + src/panels/lovelace/editor/hui-entities-card-row-editor.ts | 1 + src/panels/lovelace/entity-rows/hui-input-number-entity-row.ts | 1 + src/panels/lovelace/entity-rows/hui-media-player-entity-row.ts | 1 + src/panels/lovelace/entity-rows/hui-number-entity-row.ts | 1 + src/state-summary/state-card-input_number.ts | 1 + 14 files changed, 14 insertions(+) diff --git a/src/components/media-player/ha-media-player-browse.ts b/src/components/media-player/ha-media-player-browse.ts index 2600758eac..e5c895e742 100644 --- a/src/components/media-player/ha-media-player-browse.ts +++ b/src/components/media-player/ha-media-player-browse.ts @@ -122,6 +122,7 @@ export class HaMediaPlayerBrowse extends LitElement { } public disconnectedCallback(): void { + super.disconnectedCallback(); if (this._resizeObserver) { this._resizeObserver.disconnect(); } diff --git a/src/panels/config/helpers/forms/ha-schedule-form.ts b/src/panels/config/helpers/forms/ha-schedule-form.ts index 5a503eef1b..d592a5ec93 100644 --- a/src/panels/config/helpers/forms/ha-schedule-form.ts +++ b/src/panels/config/helpers/forms/ha-schedule-form.ts @@ -112,6 +112,7 @@ class HaScheduleForm extends LitElement { } public disconnectedCallback(): void { + super.disconnectedCallback(); if (this._resizeObserver) { this._resizeObserver.disconnect(); } diff --git a/src/panels/developer-tools/template/developer-tools-template.ts b/src/panels/developer-tools/template/developer-tools-template.ts index c7618b38d5..c977bdba83 100644 --- a/src/panels/developer-tools/template/developer-tools-template.ts +++ b/src/panels/developer-tools/template/developer-tools-template.ts @@ -62,6 +62,7 @@ class HaPanelDevTemplate extends LitElement { } public disconnectedCallback() { + super.disconnectedCallback(); this._unsubscribeTemplate(); } diff --git a/src/panels/lovelace/cards/hui-calendar-card.ts b/src/panels/lovelace/cards/hui-calendar-card.ts index 855825f65d..3ade43b753 100644 --- a/src/panels/lovelace/cards/hui-calendar-card.ts +++ b/src/panels/lovelace/cards/hui-calendar-card.ts @@ -113,6 +113,7 @@ export class HuiCalendarCard extends LitElement implements LovelaceCard { } public disconnectedCallback(): void { + super.disconnectedCallback(); if (this._resizeObserver) { this._resizeObserver.disconnect(); } diff --git a/src/panels/lovelace/cards/hui-markdown-card.ts b/src/panels/lovelace/cards/hui-markdown-card.ts index 59dfd15265..0cf9f5c4e4 100644 --- a/src/panels/lovelace/cards/hui-markdown-card.ts +++ b/src/panels/lovelace/cards/hui-markdown-card.ts @@ -69,6 +69,7 @@ export class HuiMarkdownCard extends LitElement implements LovelaceCard { } public disconnectedCallback() { + super.disconnectedCallback(); this._tryDisconnect(); } diff --git a/src/panels/lovelace/cards/hui-media-control-card.ts b/src/panels/lovelace/cards/hui-media-control-card.ts index fcd449cdf0..04e8773237 100644 --- a/src/panels/lovelace/cards/hui-media-control-card.ts +++ b/src/panels/lovelace/cards/hui-media-control-card.ts @@ -130,6 +130,7 @@ export class HuiMediaControlCard extends LitElement implements LovelaceCard { } public disconnectedCallback(): void { + super.disconnectedCallback(); if (this._progressInterval) { clearInterval(this._progressInterval); this._progressInterval = undefined; diff --git a/src/panels/lovelace/cards/hui-weather-forecast-card.ts b/src/panels/lovelace/cards/hui-weather-forecast-card.ts index 46b0e67cda..2dfd3a3a88 100644 --- a/src/panels/lovelace/cards/hui-weather-forecast-card.ts +++ b/src/panels/lovelace/cards/hui-weather-forecast-card.ts @@ -124,6 +124,7 @@ class HuiWeatherForecastCard extends LitElement implements LovelaceCard { } public disconnectedCallback(): void { + super.disconnectedCallback(); if (this._resizeObserver) { this._resizeObserver.disconnect(); } diff --git a/src/panels/lovelace/components/hui-entity-editor.ts b/src/panels/lovelace/components/hui-entity-editor.ts index ca0a8303c1..870058d349 100644 --- a/src/panels/lovelace/components/hui-entity-editor.ts +++ b/src/panels/lovelace/components/hui-entity-editor.ts @@ -33,6 +33,7 @@ export class HuiEntityEditor extends LitElement { private _sortable?: SortableInstance; public disconnectedCallback() { + super.disconnectedCallback(); this._destroySortable(); } diff --git a/src/panels/lovelace/editor/config-elements/hui-tile-card-features-editor.ts b/src/panels/lovelace/editor/config-elements/hui-tile-card-features-editor.ts index de176cc217..1db19aa31f 100644 --- a/src/panels/lovelace/editor/config-elements/hui-tile-card-features-editor.ts +++ b/src/panels/lovelace/editor/config-elements/hui-tile-card-features-editor.ts @@ -107,6 +107,7 @@ export class HuiTileCardFeaturesEditor extends LitElement { private _sortable?: SortableInstance; public disconnectedCallback() { + super.disconnectedCallback(); this._destroySortable(); } diff --git a/src/panels/lovelace/editor/hui-entities-card-row-editor.ts b/src/panels/lovelace/editor/hui-entities-card-row-editor.ts index d34f656ab4..950ce84d41 100644 --- a/src/panels/lovelace/editor/hui-entities-card-row-editor.ts +++ b/src/panels/lovelace/editor/hui-entities-card-row-editor.ts @@ -37,6 +37,7 @@ export class HuiEntitiesCardRowEditor extends LitElement { private _sortable?: SortableInstance; public disconnectedCallback() { + super.disconnectedCallback(); this._destroySortable(); } diff --git a/src/panels/lovelace/entity-rows/hui-input-number-entity-row.ts b/src/panels/lovelace/entity-rows/hui-input-number-entity-row.ts index 6488d33843..9281d2391f 100644 --- a/src/panels/lovelace/entity-rows/hui-input-number-entity-row.ts +++ b/src/panels/lovelace/entity-rows/hui-input-number-entity-row.ts @@ -49,6 +49,7 @@ class HuiInputNumberEntityRow extends LitElement implements LovelaceRow { } public disconnectedCallback(): void { + super.disconnectedCallback(); this._resizeObserver?.disconnect(); } diff --git a/src/panels/lovelace/entity-rows/hui-media-player-entity-row.ts b/src/panels/lovelace/entity-rows/hui-media-player-entity-row.ts index ab2de02d9a..daf1aa150c 100644 --- a/src/panels/lovelace/entity-rows/hui-media-player-entity-row.ts +++ b/src/panels/lovelace/entity-rows/hui-media-player-entity-row.ts @@ -68,6 +68,7 @@ class HuiMediaPlayerEntityRow extends LitElement implements LovelaceRow { } public disconnectedCallback(): void { + super.disconnectedCallback(); this._resizeObserver?.unobserve(this); } diff --git a/src/panels/lovelace/entity-rows/hui-number-entity-row.ts b/src/panels/lovelace/entity-rows/hui-number-entity-row.ts index bd55652798..7b4d2a6848 100644 --- a/src/panels/lovelace/entity-rows/hui-number-entity-row.ts +++ b/src/panels/lovelace/entity-rows/hui-number-entity-row.ts @@ -49,6 +49,7 @@ class HuiNumberEntityRow extends LitElement implements LovelaceRow { } public disconnectedCallback(): void { + super.disconnectedCallback(); this._resizeObserver?.disconnect(); } diff --git a/src/state-summary/state-card-input_number.ts b/src/state-summary/state-card-input_number.ts index 6cd218fb03..6deb14392b 100644 --- a/src/state-summary/state-card-input_number.ts +++ b/src/state-summary/state-card-input_number.ts @@ -35,6 +35,7 @@ class StateCardInputNumber extends LitElement { } public disconnectedCallback(): void { + super.disconnectedCallback(); this._resizeObserver?.disconnect(); }