🧹 remove unused configs when empty (#2347)

* Remove unused configs when empty

* Handle unused numbers & fix glance entities

* Sneak in the chunk names

src/panels/lovelace/cards/hui-alarm-panel-card.ts

@@ -41,7 +41,7 @@ export interface Config extends LovelaceCardConfig {
 class HuiAlarmPanelCard extends hassLocalizeLitMixin(LitElement)
   implements LovelaceCard {
   public static async getConfigElement() {
-    await import("../editor/config-elements/hui-alarm-panel-card-editor");
+    await import(/* webpackChunkName: "hui-alarm-panel-card-editor" */ "../editor/config-elements/hui-alarm-panel-card-editor");
     return document.createElement("hui-alarm-panel-card-editor");
   }
 

src/panels/lovelace/cards/hui-entities-card.ts

@@ -40,7 +40,7 @@ export interface Config extends LovelaceCardConfig {
 class HuiEntitiesCard extends hassLocalizeLitMixin(LitElement)
   implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-entities-card-editor");
+    await import(/* webpackChunkName: "hui-entities-card-editor" */ "../editor/config-elements/hui-entities-card-editor");
     return document.createElement("hui-entities-card-editor");
   }
 

src/panels/lovelace/cards/hui-gauge-card.ts

@@ -47,7 +47,7 @@ export const severityMap = {
 
 class HuiGaugeCard extends LitElement implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-gauge-card-editor");
+    await import(/* webpackChunkName: "hui-gauge-card-editor" */ "../editor/config-elements/hui-gauge-card-editor");
     return document.createElement("hui-gauge-card-editor");
   }
   public static getStubConfig(): object {

src/panels/lovelace/cards/hui-glance-card.ts

@@ -41,7 +41,7 @@ export interface Config extends LovelaceCardConfig {
 export class HuiGlanceCard extends hassLocalizeLitMixin(LitElement)
   implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-glance-card-editor");
+    await import(/* webpackChunkName: "hui-glance-card-editor" */ "../editor/config-elements/hui-glance-card-editor");
     return document.createElement("hui-glance-card-editor");
   }
   public static getStubConfig(): object {

src/panels/lovelace/cards/hui-iframe-card.ts

@@ -15,7 +15,7 @@ export interface Config extends LovelaceCardConfig {
 
 export class HuiIframeCard extends LitElement implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-iframe-card-editor");
+    await import(/* webpackChunkName: "hui-iframe-card-editor" */ "../editor/config-elements/hui-iframe-card-editor");
     return document.createElement("hui-iframe-card-editor");
   }
   public static getStubConfig(): object {

src/panels/lovelace/cards/hui-light-card.ts

@@ -48,7 +48,7 @@ export interface Config extends LovelaceCardConfig {
 export class HuiLightCard extends hassLocalizeLitMixin(LitElement)
   implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-light-card-editor");
+    await import(/* webpackChunkName: "hui-light-card-editor" */ "../editor/config-elements/hui-light-card-editor");
     return document.createElement("hui-light-card-editor");
   }
   public static getStubConfig(): object {

src/panels/lovelace/cards/hui-markdown-card.ts

@@ -15,7 +15,7 @@ export interface Config extends LovelaceCardConfig {
 
 export class HuiMarkdownCard extends LitElement implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-markdown-card-editor");
+    await import(/* webpackChunkName: "hui-markdown-card-editor" */ "../editor/config-elements/hui-markdown-card-editor");
     return document.createElement("hui-markdown-card-editor");
   }
   public static getStubConfig(): object {

src/panels/lovelace/cards/hui-media-control-card.js

@@ -9,7 +9,7 @@ export const Config = {
 
 class HuiMediaControlCard extends LegacyWrapperCard {
   static async getConfigElement() {
-    await import("../editor/config-elements/hui-media-control-card-editor");
+    await import(/* webpackChunkName: "hui-media-control-card-editor" */ "../editor/config-elements/hui-media-control-card-editor");
     return document.createElement("hui-media-control-card-editor");
   }
 

src/panels/lovelace/cards/hui-plant-status-card.js

@@ -10,7 +10,7 @@ export const Config = {
 
 class HuiPlantStatusCard extends LegacyWrapperCard {
   static async getConfigElement() {
-    await import("../editor/config-elements/hui-plant-status-card-editor");
+    await import(/* webpackChunkName: "hui-plant-status-card-editor" */ "../editor/config-elements/hui-plant-status-card-editor");
     return document.createElement("hui-plant-status-card-editor");
   }
 

src/panels/lovelace/cards/hui-sensor-card.ts

@@ -146,7 +146,7 @@ export interface Config extends LovelaceCardConfig {
 
 class HuiSensorCard extends LitElement implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-sensor-card-editor");
+    await import(/* webpackChunkName: "hui-sensor-card-editor" */ "../editor/config-elements/hui-sensor-card-editor");
     return document.createElement("hui-sensor-card-editor");
   }
 

src/panels/lovelace/cards/hui-shopping-list-card.ts

@@ -26,7 +26,7 @@ export interface Config extends LovelaceCardConfig {
 class HuiShoppingListCard extends hassLocalizeLitMixin(LitElement)
   implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-shopping-list-editor");
+    await import(/* webpackChunkName: "hui-shopping-list-editor" */ "../editor/config-elements/hui-shopping-list-editor");
     return document.createElement("hui-shopping-list-card-editor");
   }
   public static getStubConfig(): object {

src/panels/lovelace/cards/hui-thermostat-card.ts

@@ -58,7 +58,7 @@ function formatTemp(temps: string[]): string {
 export class HuiThermostatCard extends hassLocalizeLitMixin(LitElement)
   implements LovelaceCard {
   public static async getConfigElement(): Promise<LovelaceCardEditor> {
-    await import("../editor/config-elements/hui-thermostat-card-editor");
+    await import(/* webpackChunkName: "hui-thermostat-card-editor" */ "../editor/config-elements/hui-thermostat-card-editor");
     return document.createElement("hui-thermostat-card-editor");
   }
 

src/panels/lovelace/editor/config-elements/hui-alarm-panel-card-editor.ts

@@ -173,11 +173,15 @@ export class HuiAlarmPanelCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue!]: target.value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-entities-card-editor.ts

@@ -115,12 +115,16 @@ export class HuiEntitiesCardEditor extends hassLocalizeLitMixin(LitElement)
       this._config.entities = ev.detail.entities;
       this._configEntities = processEditorEntities(this._config.entities);
     } else if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue]:
             target.checked !== undefined ? target.checked : target.value,
         };
       }
+    }
 
     fireEvent(this, "config-changed", { config: this._config });
   }

src/panels/lovelace/editor/config-elements/hui-gauge-card-editor.ts

@@ -218,12 +218,19 @@ export class HuiGaugeCardEditor extends hassLocalizeLitMixin(LitElement)
     const target = ev.target! as EditorTarget;
 
     if (target.configValue) {
+      if (
+        target.value === "" ||
+        (target.type === "number" && isNaN(Number(target.value)))
+      ) {
+        delete this._config[target.configValue!];
+      } else {
         let value: any = target.value;
         if (target.type === "number") {
           value = Number(value);
         }
         this._config = { ...this._config, [target.configValue!]: value };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-glance-card-editor.ts

@@ -64,8 +64,8 @@ export class HuiGlanceCardEditor extends hassLocalizeLitMixin(LitElement)
     return this._config!.theme || "Backend-selected";
   }
 
-  get _columns(): string {
+  get _columns(): number {
-    return this._config!.columns ? String(this._config!.columns) : "";
+    return this._config!.columns || NaN;
   }
 
   protected render(): TemplateResult {
@@ -126,13 +126,19 @@ export class HuiGlanceCardEditor extends hassLocalizeLitMixin(LitElement)
     }
     const target = ev.target! as EditorTarget;
 
-    if (this[`_${target.configValue}`] === target.value) {
+    if (target.configValue && this[`_${target.configValue}`] === target.value) {
       return;
     }
     if (ev.detail && ev.detail.entities) {
       this._config.entities = ev.detail.entities;
       this._configEntities = processEditorEntities(this._config.entities);
     } else if (target.configValue) {
+      if (
+        target.value === "" ||
+        (target.type === "number" && isNaN(Number(target.value)))
+      ) {
+        delete this._config[target.configValue!];
+      } else {
         let value: any = target.value;
         if (target.type === "number") {
           value = Number(value);
@@ -143,6 +149,7 @@ export class HuiGlanceCardEditor extends hassLocalizeLitMixin(LitElement)
             target.checked !== undefined ? target.checked : value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-iframe-card-editor.ts

@@ -92,8 +92,12 @@ export class HuiIframeCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = { ...this._config, [target.configValue!]: value };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-light-card-editor.ts

@@ -91,11 +91,15 @@ export class HuiLightCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue!]: target.value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-markdown-card-editor.ts

@@ -77,11 +77,15 @@ export class HuiMarkdownCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue!]: target.value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-media-control-card-editor.ts

@@ -62,11 +62,15 @@ export class HuiMediaControlCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue!]: target.value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-plant-status-card-editor.ts

@@ -79,11 +79,15 @@ export class HuiPlantStatusCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue!]: target.value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-sensor-card-editor.ts

@@ -171,14 +171,18 @@ export class HuiSensorCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (
+        target.value === "" ||
+        (target.type === "number" && isNaN(Number(target.value)))
+      ) {
+        delete this._config[target.configValue!];
+      } else {
         let value: any = target.value;
         if (target.type === "number") {
           value = Number(value);
         }
-      this._config = {
+        this._config = { ...this._config, [target.configValue!]: value };
-        ...this._config,
+      }
-        [target.configValue!]: value,
-      };
     }
     fireEvent(this, "config-changed", { config: this._config });
   }

src/panels/lovelace/editor/config-elements/hui-shopping-list-editor.ts

@@ -60,11 +60,15 @@ export class HuiShoppingListEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = {
           ...this._config,
           [target.configValue!]: target.value,
         };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }

src/panels/lovelace/editor/config-elements/hui-thermostat-card-editor.ts

@@ -91,8 +91,12 @@ export class HuiThermostatCardEditor extends hassLocalizeLitMixin(LitElement)
       return;
     }
     if (target.configValue) {
+      if (target.value === "") {
+        delete this._config[target.configValue!];
+      } else {
         this._config = { ...this._config, [target.configValue!]: target.value };
       }
+    }
     fireEvent(this, "config-changed", { config: this._config });
   }
 }