From cd90e7b37602a007cc8863ce07e2125ce77fceee Mon Sep 17 00:00:00 2001 From: Simon Lamon <32477463+silamon@users.noreply.github.com> Date: Thu, 17 Apr 2025 20:00:58 +0200 Subject: [PATCH] PR review --- .github/workflows/cast_deployment.yaml | 18 ++++++++++-------- .github/workflows/demo_deployment.yaml | 18 ++++++++++-------- .github/workflows/design_deployment.yaml | 9 +++++---- .github/workflows/design_preview.yaml | 7 ++++--- 4 files changed, 29 insertions(+), 23 deletions(-) diff --git a/.github/workflows/cast_deployment.yaml b/.github/workflows/cast_deployment.yaml index 87431ab34e..14bd4b18fc 100644 --- a/.github/workflows/cast_deployment.yaml +++ b/.github/workflows/cast_deployment.yaml @@ -42,10 +42,11 @@ jobs: - name: Deploy to Netlify id: deploy run: | - npm install netlify-cli -g - netlify deploy --dir=cast/dist --alias dev \ - --auth ${{ secrets.NETLIFY_AUTH_TOKEN }} \ - --site ${{ secrets.NETLIFY_CAST_SITE_ID }} + npx install netlify-cli -g + netlify deploy --dir=cast/dist --alias dev + env: + NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} + NETLIFY_SITE_ID: ${{ secrets.NETLIFY_CAST_SITE_ID }} deploy_master: runs-on: ubuntu-latest @@ -77,7 +78,8 @@ jobs: - name: Deploy to Netlify id: deploy run: | - npm install netlify-cli -g - netlify deploy --dir=cast/dist --prod \ - --auth ${{ secrets.NETLIFY_AUTH_TOKEN }} \ - --site ${{ secrets.NETLIFY_CAST_SITE_ID }} + npx install netlify-cli -g + netlify deploy --dir=cast/dist --prod + env: + NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} + NETLIFY_SITE_ID: ${{ secrets.NETLIFY_CAST_SITE_ID }} diff --git a/.github/workflows/demo_deployment.yaml b/.github/workflows/demo_deployment.yaml index ab6f869443..61cc474c79 100644 --- a/.github/workflows/demo_deployment.yaml +++ b/.github/workflows/demo_deployment.yaml @@ -43,10 +43,11 @@ jobs: - name: Deploy to Netlify id: deploy run: | - npm install netlify-cli -g - netlify deploy --dir=demo/dist --prod \ - --auth ${{ secrets.NETLIFY_AUTH_TOKEN }} \ - --site ${{ secrets.NETLIFY_DEMO_DEV_SITE_ID }} + npx install netlify-cli -g + netlify deploy --dir=demo/dist --prod + env: + NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} + NETLIFY_SITE_ID: ${{ secrets.NETLIFY_DEMO_DEV_SITE_ID }} deploy_master: runs-on: ubuntu-latest @@ -78,7 +79,8 @@ jobs: - name: Deploy to Netlify id: deploy run: | - npm install netlify-cli -g - netlify deploy --dir=demo/dist --prod \ - --auth ${{ secrets.NETLIFY_AUTH_TOKEN }} \ - --site ${{ secrets.NETLIFY_DEMO_SITE_ID }} + npx install netlify-cli -g + netlify deploy --dir=demo/dist --prod + env: + NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} + NETLIFY_SITE_ID: ${{ secrets.NETLIFY_DEMO_SITE_ID }} diff --git a/.github/workflows/design_deployment.yaml b/.github/workflows/design_deployment.yaml index e51c4bd6c7..2e0f2c2424 100644 --- a/.github/workflows/design_deployment.yaml +++ b/.github/workflows/design_deployment.yaml @@ -35,7 +35,8 @@ jobs: - name: Deploy to Netlify id: deploy run: | - npm install netlify-cli -g - netlify deploy --dir=gallery/dist --prod \ - --auth ${{ secrets.NETLIFY_AUTH_TOKEN }} \ - --site ${{ secrets.NETLIFY_GALLERY_SITE_ID }} + npx install netlify-cli -g + netlify deploy --dir=gallery/dist --prod + env: + NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} + NETLIFY_SITE_ID: ${{ secrets.NETLIFY_GALLERY_SITE_ID }} diff --git a/.github/workflows/design_preview.yaml b/.github/workflows/design_preview.yaml index c34e6dc2af..8d6c0bc67a 100644 --- a/.github/workflows/design_preview.yaml +++ b/.github/workflows/design_preview.yaml @@ -40,11 +40,12 @@ jobs: - name: Deploy preview to Netlify id: deploy run: | - npm install netlify-cli -g + npx install netlify-cli -g netlify deploy --dir=gallery/dist --alias "deploy-preview-${{ github.event.number }}" \ - --auth ${{ secrets.NETLIFY_AUTH_TOKEN }} \ - --site ${{ secrets.NETLIFY_GALLERY_SITE_ID }} \ --json > deploy_output.json + env: + NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }} + NETLIFY_SITE_ID: ${{ secrets.NETLIFY_GALLERY_SITE_ID }} - name: Generate summary run: |