From d968a2086285c3d6b14e3e326a443ad0ad182dc6 Mon Sep 17 00:00:00 2001 From: karwosts <32912880+karwosts@users.noreply.github.com> Date: Tue, 28 Nov 2023 11:19:49 -0800 Subject: [PATCH] More disconnected callback errors (#18792) --- src/onboarding/ha-onboarding.ts | 2 +- .../config/voice-assistants/ha-config-voice-assistants.ts | 2 +- src/panels/media-browser/ha-bar-media-player.ts | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/onboarding/ha-onboarding.ts b/src/onboarding/ha-onboarding.ts index 8cd3f0fab4..f69b536941 100644 --- a/src/onboarding/ha-onboarding.ts +++ b/src/onboarding/ha-onboarding.ts @@ -114,7 +114,7 @@ class HaOnboarding extends litLocalizeLiteMixin(HassElement) { } disconnectedCallback() { - super.connectedCallback(); + super.disconnectedCallback(); mainWindow.removeEventListener("location-changed", this._updatePage); mainWindow.removeEventListener("popstate", this._updatePage); } diff --git a/src/panels/config/voice-assistants/ha-config-voice-assistants.ts b/src/panels/config/voice-assistants/ha-config-voice-assistants.ts index 2ea1fc334c..dd827fcfe0 100644 --- a/src/panels/config/voice-assistants/ha-config-voice-assistants.ts +++ b/src/panels/config/voice-assistants/ha-config-voice-assistants.ts @@ -52,7 +52,7 @@ class HaConfigVoiceAssistants extends HassRouterPage { } public disconnectedCallback(): void { - super.connectedCallback(); + super.disconnectedCallback(); this.removeEventListener( "exposed-entities-changed", this._fetchExposedEntities diff --git a/src/panels/media-browser/ha-bar-media-player.ts b/src/panels/media-browser/ha-bar-media-player.ts index efda587950..4575396d5e 100644 --- a/src/panels/media-browser/ha-bar-media-player.ts +++ b/src/panels/media-browser/ha-bar-media-player.ts @@ -109,6 +109,7 @@ export class BarMediaPlayer extends SubscribeMixin(LitElement) { } public disconnectedCallback(): void { + super.disconnectedCallback(); if (this._progressInterval) { clearInterval(this._progressInterval); this._progressInterval = undefined;