jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-21 16:26:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Close notification drawer after dismissing last notification (#7229)

Browse Source 
* Close notification drawer after dismissing last

This change adds a listener to any changes of the notifications property once the drawer opens. After the last notification is dismissed, the notification drawer closes automatically, and the listener is removed.

* Use observer instead event for notification change

Using the observer pattern instead subscribing to change events for notification changes simplifies the implementation noticeably.
This commit is contained in:
Matt 2020-10-12 02:25:04 -06:00 committed by GitHub
parent c219f64322
commit d9a954ca91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/dialogs/notifications/notification-drawer.js
View File

@ -88,6 +88,7 @@ export class HuiNotificationDrawer extends EventsMixin(
notifications: { notifications: {
type: Array, type: Array,
computed: "_computeNotifications(open, hass, _notificationsBackend)", computed: "_computeNotifications(open, hass, _notificationsBackend)",
observer: "_notificationsChanged",
}, },
_notificationsBackend: { _notificationsBackend: {
type: Array, type: Array,
@ -130,6 +131,17 @@ export class HuiNotificationDrawer extends EventsMixin(
} }
} }
_notificationsChanged(newNotifications, oldNotifications) {
// automatically close drawer when last notification has been dismissed
if (
this.open &&
oldNotifications.length > 0 &&
!newNotifications.length === 0
) {
this.open = false;
}
}
_computeNotifications(open, hass, notificationsBackend) { _computeNotifications(open, hass, notificationsBackend) {
if (!open) { if (!open) {
return []; return [];