From dcf50e055b21f59e86bad5e473305ed0d75048fb Mon Sep 17 00:00:00 2001 From: Zack Barett Date: Mon, 14 Mar 2022 11:11:46 -0500 Subject: [PATCH] Fix @changed where using ev.detail (#12043) --- src/panels/config/users/dialog-user-detail.ts | 5 ++--- .../editor/config-elements/hui-picture-card-editor.ts | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/panels/config/users/dialog-user-detail.ts b/src/panels/config/users/dialog-user-detail.ts index 9729262167..490839b3cd 100644 --- a/src/panels/config/users/dialog-user-detail.ts +++ b/src/panels/config/users/dialog-user-detail.ts @@ -22,7 +22,6 @@ import { showAlertDialog, showPromptDialog, } from "../../../dialogs/generic/show-dialog-box"; -import { PolymerChangedEvent } from "../../../polymer-types"; import { haStyleDialog } from "../../../resources/styles"; import { HomeAssistant } from "../../../types"; import { UserDetailDialogParams } from "./show-dialog-user-detail"; @@ -212,9 +211,9 @@ class DialogUserDetail extends LitElement { `; } - private _nameChanged(ev: PolymerChangedEvent) { + private _nameChanged(ev) { this._error = undefined; - this._name = ev.detail.value; + this._name = ev.target.value; } private _adminChanged(ev): void { diff --git a/src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts b/src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts index 9b1f46f96b..0df731ba97 100644 --- a/src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts +++ b/src/panels/lovelace/editor/config-elements/hui-picture-card-editor.ts @@ -113,9 +113,9 @@ export class HuiPictureCardEditor return; } const target = ev.target! as EditorTarget; - const value = ev.detail.value; + const value = ev.detail?.value ?? target.value; - if (this[`_${target.configValue}`] === target.value) { + if (this[`_${target.configValue}`] === value) { return; } if (target.configValue) {