From de292a8143e6931688259a75283b3142781abf51 Mon Sep 17 00:00:00 2001 From: jonnynch Date: Mon, 9 Sep 2024 01:23:47 +1000 Subject: [PATCH] Fix WebRTC for Firefox by ignoring empty ice candidates (#21908) * handle firefox empty string ice candidate * use optional chaining as per comment --- src/components/ha-web-rtc-player.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ha-web-rtc-player.ts b/src/components/ha-web-rtc-player.ts index 84707673d1..aca8ff001d 100644 --- a/src/components/ha-web-rtc-player.ts +++ b/src/components/ha-web-rtc-player.ts @@ -109,7 +109,7 @@ class HaWebRtcPlayer extends LitElement { let candidates = ""; // Build an Offer SDP string with ice candidates const iceResolver = new Promise((resolve) => { peerConnection.addEventListener("icecandidate", async (event) => { - if (!event.candidate) { + if (!event.candidate?.candidate) { resolve(); // Gathering complete return; }