From ea5ee6189de3d6542b2f17d4ed97919ba2093c9b Mon Sep 17 00:00:00 2001 From: Ian Richardson Date: Tue, 15 Oct 2019 19:19:46 -0500 Subject: [PATCH] filter system users from Person editor (#3958) * filter system users from Person editor * address review comments * address comments * address comments --- src/components/user/ha-user-picker.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/components/user/ha-user-picker.ts b/src/components/user/ha-user-picker.ts index d162842cfb..817f1fa4c9 100644 --- a/src/components/user/ha-user-picker.ts +++ b/src/components/user/ha-user-picker.ts @@ -18,19 +18,20 @@ import { fireEvent } from "../../common/dom/fire_event"; import { User, fetchUsers } from "../../data/user"; import { compare } from "../../common/string/compare"; -class HaEntityPicker extends LitElement { +class HaUserPicker extends LitElement { public hass?: HomeAssistant; @property() public label?: string; @property() public value?: string; @property() public users?: User[]; private _sortedUsers = memoizeOne((users?: User[]) => { - if (!users || users.length === 1) { - return users || []; + if (!users) { + return []; } - const sorted = [...users]; - sorted.sort((a, b) => compare(a.name, b.name)); - return sorted; + + return users + .filter((user) => !user.system_generated) + .sort((a, b) => compare(a.name, b.name)); }); protected render(): TemplateResult | void { @@ -101,4 +102,4 @@ class HaEntityPicker extends LitElement { } } -customElements.define("ha-user-picker", HaEntityPicker); +customElements.define("ha-user-picker", HaUserPicker);