jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-08-02 05:57:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add warning when using templates in service dev tools

Browse Source
This commit is contained in:
Franck Nijhof 2021-03-12 12:41:08 +01:00
parent 3b837e1d54
commit f64b96ac5d
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/panels/developer-tools/service/developer-tools-service.ts
View File

@ -4,6 +4,7 @@ import {
CSSResultArray,
html,
LitElement,
internalProperty,
property,
query,
} from "lit-element";
@ -25,12 +26,15 @@ import { haStyle } from "../../../resources/styles";
import "../../../styles/polymer-ha-style";
import { HomeAssistant } from "../../../types";
import "../../../util/app-localstorage-document";
import { hasTemplate } from "../../../common/string/has-template";
class HaPanelDevService extends LitElement {
@property({ attribute: false }) public hass!: HomeAssistant;
@property() public narrow!: boolean;
@internalProperty() private _error?: string;
@LocalStorage("panel-dev-service-state-service-data", true)
private _serviceData?: ServiceAction = { service: "", target: {}, data: {} };
@ -84,7 +88,6 @@ class HaPanelDevService extends LitElement {
"ui.panel.developer-tools.tabs.services.description"
)}
</p>
${this._yamlMode
? html`<ha-service-picker
.hass=${this.hass}
@ -105,6 +108,7 @@ class HaPanelDevService extends LitElement {
@value-changed=${this._serviceDataChanged}
></ha-service-control></div
></ha-card>`}
${this._error ? html` <p class="error">Error: ${this._error}</p> ` : ""}
</div>
<div class="button-row">
<div class="buttons">
@ -255,6 +259,15 @@ class HaPanelDevService extends LitElement {
if (!domain || !service) {
return;
}
this._error = undefined;
if (hasTemplate(this._serviceData!)) {
this._error = this.hass.localize(
"ui.panel.developer-tools.tabs.services.no_templates"
);
return;
}
this.hass.callService(
domain,
service,

3
src/translations/en.json
View File

@ -3340,7 +3340,8 @@
"ui_mode": "Go to UI mode",
"yaml_parameters": "Parameters only available in YAML mode",
"all_parameters": "All available parameters",
"accepts_target": "This service accepts a target, for example: `entity_id: light.bed_light`"
"accepts_target": "This service accepts a target, for example: `entity_id: light.bed_light`",
"no_templates": "The service dev tools does not support the use of Jinja templates"
},
"states": {
"title": "States",