jeans/frontend
jeans/frontend
1
0
Fork 0
mirror of https://github.com/home-assistant/frontend.git synced 2025-07-14 12:56:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIx console errors in charts (#24048)

Browse Source 
* FIx console errors in charts

* handle undefined unit_of_measurement
This commit is contained in:
Petar Petrov 2025-02-03 19:13:35 +02:00 committed by Bram Kragten
parent b263b74916
commit fcf655b0ec
4 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/chart/ha-chart-base.ts
View File

@ -143,15 +143,7 @@ export class HaChartBase extends LitElement {
this.chart.setOption(this._createOptions(), { this.chart.setOption(this._createOptions(), {
lazyUpdate: true, lazyUpdate: true,
// if we replace the whole object, it will reset the dataZoom // if we replace the whole object, it will reset the dataZoom
replaceMerge: [ replaceMerge: ["grid"],
"xAxis",
"yAxis",
"dataZoom",
"dataset",
"tooltip",
"grid",
"visualMap",
],
}); });
} }
} }
@ -503,6 +495,7 @@ export class HaChartBase extends LitElement {
private _handleZoomReset() { private _handleZoomReset() {
this.chart?.dispatchAction({ type: "dataZoom", start: 0, end: 100 }); this.chart?.dispatchAction({ type: "dataZoom", start: 0, end: 100 });
this._modifierPressed = false;
} }
private _handleWheel(e: WheelEvent) { private _handleWheel(e: WheelEvent) {

3
src/components/chart/state-history-chart-line.ts
View File

@ -132,6 +132,7 @@ export class StateHistoryChartLine extends LitElement {
marker: `<span style="display:inline-block;margin-right:4px;border-radius:10px;width:10px;height:10px;background-color:${dataset.color};"></span>`, marker: `<span style="display:inline-block;margin-right:4px;border-radius:10px;width:10px;height:10px;background-color:${dataset.color};"></span>`,
}); });
}); });
const unit = this.unit ? ` ${this.unit}` : "";
return ( return (
title + title +
datapoints datapoints
@ -143,7 +144,7 @@ export class StateHistoryChartLine extends LitElement {
undefined, undefined,
this.hass.entities[this._entityIds[param.seriesIndex]] this.hass.entities[this._entityIds[param.seriesIndex]]
) )
)} ${this.unit}`; )}${unit}`;
const dataIndex = this._datasetToDataIndex[param.seriesIndex]; const dataIndex = this._datasetToDataIndex[param.seriesIndex];
const data = this.data[dataIndex]; const data = this.data[dataIndex];
if (data.statistics && data.statistics.length > 0) { if (data.statistics && data.statistics.length > 0) {

3
src/components/chart/statistics-chart.ts
View File

@ -186,6 +186,7 @@ export class StatisticsChart extends LitElement {
private _renderTooltip = (params: any) => { private _renderTooltip = (params: any) => {
const rendered: Record<string, boolean> = {}; const rendered: Record<string, boolean> = {};
const unit = this.unit ? ` ${this.unit}` : "";
return params return params
.map((param, index: number) => { .map((param, index: number) => {
if (rendered[param.seriesName]) return ""; if (rendered[param.seriesName]) return "";
@ -198,7 +199,7 @@ export class StatisticsChart extends LitElement {
undefined, undefined,
this.hass.entities[this._statisticIds[param.seriesIndex]] this.hass.entities[this._statisticIds[param.seriesIndex]]
) )
)} ${this.unit}`; )}${unit}`;
const time = const time =
index === 0 index === 0

5
src/state/logging-mixin.ts
View File

@ -33,10 +33,7 @@ export const loggingMixin = <T extends Constructor<HassBaseEl>>(
ev.message.includes("ResizeObserver loop limit exceeded")) || ev.message.includes("ResizeObserver loop limit exceeded")) ||
ev.message.includes( ev.message.includes(
"ResizeObserver loop completed with undelivered notifications" "ResizeObserver loop completed with undelivered notifications"
) || )
(ev.error.stack.includes("DataZoomModel") &&
(ev.message.includes("undefined") ||
ev.message.includes("Cannot read properties of null")))
) { ) {
ev.preventDefault(); ev.preventDefault();
ev.stopImmediatePropagation(); ev.stopImmediatePropagation();