Fix various supervisor tooltip and aria-label issues (#10878)

This commit is contained in:
Philip Allgaier 2022-01-25 17:36:35 +01:00 committed by GitHub
parent c4cad5bccd
commit ffaff30b46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 47 additions and 30 deletions

View File

@ -114,7 +114,7 @@ class HassioAddonConfig extends LitElement {
<div class="card-menu"> <div class="card-menu">
<ha-button-menu corner="BOTTOM_START" @action=${this._handleAction}> <ha-button-menu corner="BOTTOM_START" @action=${this._handleAction}>
<ha-icon-button <ha-icon-button
.label=${this.hass.localize("common.menu")} .label=${this.supervisor.localize("common.menu")}
.path=${mdiDotsVertical} .path=${mdiDotsVertical}
slot="trigger" slot="trigger"
></ha-icon-button> ></ha-icon-button>

View File

@ -191,7 +191,7 @@ export class HassioBackups extends LitElement {
@action=${this._handleAction} @action=${this._handleAction}
> >
<ha-icon-button <ha-icon-button
.label=${this.hass.localize("common.menu")} .label=${this.supervisor?.localize("common.menu")}
.path=${mdiDotsVertical} .path=${mdiDotsVertical}
slot="trigger" slot="trigger"
></ha-icon-button> ></ha-icon-button>

View File

@ -17,27 +17,27 @@ export class DialogHassioBackupUpload
{ {
@property({ attribute: false }) public hass?: HomeAssistant; @property({ attribute: false }) public hass?: HomeAssistant;
@state() private _params?: HassioBackupUploadDialogParams; @state() private _dialogParams?: HassioBackupUploadDialogParams;
public async showDialog( public async showDialog(
params: HassioBackupUploadDialogParams dialogParams: HassioBackupUploadDialogParams
): Promise<void> { ): Promise<void> {
this._params = params; this._dialogParams = dialogParams;
await this.updateComplete; await this.updateComplete;
} }
public closeDialog(): void { public closeDialog(): void {
if (this._params && !this._params.onboarding) { if (this._dialogParams && !this._dialogParams.onboarding) {
if (this._params.reloadBackup) { if (this._dialogParams.reloadBackup) {
this._params.reloadBackup(); this._dialogParams.reloadBackup();
} }
} }
this._params = undefined; this._dialogParams = undefined;
fireEvent(this, "dialog-closed", { dialog: this.localName }); fireEvent(this, "dialog-closed", { dialog: this.localName });
} }
protected render(): TemplateResult { protected render(): TemplateResult {
if (!this._params) { if (!this._dialogParams) {
return html``; return html``;
} }
@ -52,9 +52,13 @@ export class DialogHassioBackupUpload
> >
<div slot="heading"> <div slot="heading">
<ha-header-bar> <ha-header-bar>
<span slot="title"> Upload backup </span> <span slot="title"
>${this.hass?.localize(
"ui.panel.page-onboarding.restore.upload_backup"
) || "Upload backup"}</span
>
<ha-icon-button <ha-icon-button
.label=${this.hass?.localize("common.close") || "close"} .label=${this.hass?.localize("ui.common.close") || "Close"}
.path=${mdiClose} .path=${mdiClose}
slot="actionItems" slot="actionItems"
dialogAction="cancel" dialogAction="cancel"
@ -71,7 +75,7 @@ export class DialogHassioBackupUpload
private _backupUploaded(ev) { private _backupUploaded(ev) {
const backup = ev.detail.backup; const backup = ev.detail.backup;
this._params?.showBackup(backup.slug); this._dialogParams?.showBackup(backup.slug);
this.closeDialog(); this.closeDialog();
} }

View File

@ -48,9 +48,9 @@ class HassioBackupDialog
@query("supervisor-backup-content") @query("supervisor-backup-content")
private _backupContent!: SupervisorBackupContent; private _backupContent!: SupervisorBackupContent;
public async showDialog(params: HassioBackupDialogParams) { public async showDialog(dialogParams: HassioBackupDialogParams) {
this._backup = await fetchHassioBackupInfo(this.hass, params.slug); this._backup = await fetchHassioBackupInfo(this.hass, dialogParams.slug);
this._dialogParams = params; this._dialogParams = dialogParams;
this._restoringBackup = false; this._restoringBackup = false;
} }
@ -77,7 +77,7 @@ class HassioBackupDialog
<ha-header-bar> <ha-header-bar>
<span slot="title">${this._backup.name}</span> <span slot="title">${this._backup.name}</span>
<ha-icon-button <ha-icon-button
.label=${this.hass?.localize("common.close") || "close"} .label=${this.hass?.localize("ui.common.close") || "Close"}
.path=${mdiClose} .path=${mdiClose}
slot="actionItems" slot="actionItems"
dialogAction="cancel" dialogAction="cancel"
@ -114,12 +114,20 @@ class HassioBackupDialog
@closed=${stopPropagation} @closed=${stopPropagation}
> >
<ha-icon-button <ha-icon-button
.label=${this.hass!.localize("common.menu")} .label=${this.hass!.localize("ui.common.menu") || "Menu"}
.path=${mdiDotsVertical} .path=${mdiDotsVertical}
slot="trigger" slot="trigger"
></ha-icon-button> ></ha-icon-button>
<mwc-list-item>Download Backup</mwc-list-item> <mwc-list-item
<mwc-list-item class="error">Delete Backup</mwc-list-item> >${this._dialogParams.supervisor?.localize(
"backup.download_backup"
)}</mwc-list-item
>
<mwc-list-item class="error"
>${this._dialogParams.supervisor?.localize(
"backup.delete_backup_title"
)}</mwc-list-item
>
</ha-button-menu>` </ha-button-menu>`
: ""} : ""}
</ha-dialog> </ha-dialog>

View File

@ -30,8 +30,8 @@ class HassioCreateBackupDialog extends LitElement {
@query("supervisor-backup-content") @query("supervisor-backup-content")
private _backupContent!: SupervisorBackupContent; private _backupContent!: SupervisorBackupContent;
public showDialog(params: HassioCreateBackupDialogParams) { public showDialog(dialogParams: HassioCreateBackupDialogParams) {
this._dialogParams = params; this._dialogParams = dialogParams;
this._creatingBackup = false; this._creatingBackup = false;
} }
@ -57,7 +57,7 @@ class HassioCreateBackupDialog extends LitElement {
)} )}
> >
${this._creatingBackup ${this._creatingBackup
? html` <ha-circular-progress active></ha-circular-progress>` ? html`<ha-circular-progress active></ha-circular-progress>`
: html`<supervisor-backup-content : html`<supervisor-backup-content
.hass=${this.hass} .hass=${this.hass}
.supervisor=${this._dialogParams.supervisor} .supervisor=${this._dialogParams.supervisor}

View File

@ -39,8 +39,8 @@ class HassioHardwareDialog extends LitElement {
@state() private _filter?: string; @state() private _filter?: string;
public showDialog(params: HassioHardwareDialogParams) { public showDialog(dialogParams: HassioHardwareDialogParams) {
this._dialogParams = params; this._dialogParams = dialogParams;
} }
public closeDialog() { public closeDialog() {
@ -72,7 +72,7 @@ class HassioHardwareDialog extends LitElement {
${this._dialogParams.supervisor.localize("dialog.hardware.title")} ${this._dialogParams.supervisor.localize("dialog.hardware.title")}
</h2> </h2>
<ha-icon-button <ha-icon-button
.label=${this.hass.localize("common.close")} .label=${this._dialogParams.supervisor.localize("common.close")}
.path=${mdiClose} .path=${mdiClose}
dialogAction="close" dialogAction="close"
></ha-icon-button> ></ha-icon-button>

View File

@ -104,7 +104,7 @@ export class DialogHassioNetwork
${this.supervisor.localize("dialog.network.title")} ${this.supervisor.localize("dialog.network.title")}
</span> </span>
<ha-icon-button <ha-icon-button
.label=${this.hass.localize("common.close")} .label=${this.supervisor.localize("common.close")}
.path=${mdiClose} .path=${mdiClose}
slot="actionItems" slot="actionItems"
dialogAction="cancel" dialogAction="cancel"

View File

@ -186,7 +186,7 @@ class HassioHostInfo extends LitElement {
<ha-button-menu corner="BOTTOM_START"> <ha-button-menu corner="BOTTOM_START">
<ha-icon-button <ha-icon-button
.label=${this.hass.localize("common.menu")} .label=${this.supervisor.localize("common.menu")}
.path=${mdiDotsVertical} .path=${mdiDotsVertical}
slot="trigger" slot="trigger"
></ha-icon-button> ></ha-icon-button>

View File

@ -77,7 +77,7 @@ export const computeLocalize = async (
await loadPolyfillLocales(language); await loadPolyfillLocales(language);
// Everytime any of the parameters change, invalidate the strings cache. // Every time any of the parameters change, invalidate the strings cache.
cache._localizationCache = {}; cache._localizationCache = {};
return (key, ...args) => { return (key, ...args) => {

View File

@ -105,6 +105,9 @@
} }
}, },
"ui": { "ui": {
"backup": {
"upload_backup": "Upload backup"
},
"card": { "card": {
"alarm_control_panel": { "alarm_control_panel": {
"code": "Code", "code": "Code",
@ -4068,7 +4071,8 @@
"addons": "[%key:supervisor::backup::addons%]", "addons": "[%key:supervisor::backup::addons%]",
"password_protection": "[%key:supervisor::backup::password_protection%]", "password_protection": "[%key:supervisor::backup::password_protection%]",
"password": "[%key:supervisor::backup::password%]", "password": "[%key:supervisor::backup::password%]",
"confirm_password": "[%key:supervisor::backup::confirm_password%]" "confirm_password": "[%key:supervisor::backup::confirm_password%]",
"upload_backup": "[%key:supervisor::backup::upload_backup%]"
} }
}, },
"custom": { "custom": {
@ -4444,6 +4448,7 @@
"failed_to_delete": "Failed to delete", "failed_to_delete": "Failed to delete",
"could_not_create": "Could not create backup", "could_not_create": "Could not create backup",
"upload_backup": "Upload backup", "upload_backup": "Upload backup",
"download_backup": "Download backup",
"create_backup": "Create backup", "create_backup": "Create backup",
"create": "Create", "create": "Create",
"created": "Created", "created": "Created",