jeans/home-assistant.io
jeans/home-assistant.io
1
0
Fork 0
mirror of https://github.com/home-assistant/home-assistant.io.git synced 2025-07-16 13:56:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update code_review_component.markdown

Browse Source
This commit is contained in:
Paulus Schoutsen 2017-08-13 14:54:41 -07:00 committed by Fabian Affolter
parent 34ee0e9848
commit 667609819e
No known key found for this signature in database
GPG Key ID: DDF3D6F44AAB1336
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/developers/code_review_component.markdown
View File

@ -19,7 +19,7 @@ Not all existing platforms follow the requirements in this checklist. This canno
1. Requirement version pinned: `REQUIREMENTS = ['phue==0.8.1']` 1. Requirement version pinned: `REQUIREMENTS = ['phue==0.8.1']`
2. We no longer want requirements hosted on GitHub. Please upload to PyPi. 2. We no longer want requirements hosted on GitHub. Please upload to PyPi.
3. Requirements only imported inside functions. This is necessary because requirements are installed on the fly. 3. Requirements should only be imported inside functions. This is necessary because requirements are installed on the fly.
### {% linkable_title Configuration %} ### {% linkable_title Configuration %}