From dc6ec5cefc2ba85ec0f4e19ac9f979e713a4d656 Mon Sep 17 00:00:00 2001 From: Stamatios Chrysinas Date: Sun, 9 Mar 2025 23:50:54 +0100 Subject: [PATCH 01/11] Update philips_js.markdown I've used the information from: https://github.com/eslavnov/pylips/blob/master/docs/Home.md to update the endpoints for the api version check. --- source/_integrations/philips_js.markdown | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 96711f088f1..ff92e30d4b8 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -24,7 +24,15 @@ ha_integration_type: integration The `philips_js` platform allows you to control Philips TVs which expose the [jointSPACE](http://jointspace.sourceforge.net/) JSON-API. -If your TV responds to `http://IP_ADDRESS_OF_TV:1925/system` then this integration can be used. In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). +**Differences between Android TVs and non-Android TVs** +1) Android TVs use `https://`, non-Android TV use `http://` +2) Android TVs primarily use port 1926, non-Android TV use port 1925 only + +For non-Android TV check if your TV responds to `http://IP_ADDRESS_OF_TV:1925/system`. + +For Android TV check if your TV responds to `https://IP_ADDRESS_OF_TV:1926/system`. + +If you get a response then this integration can be used. In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. This is true at least for some models before year 2011. Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. From f5d000fd7018c40861a5c2fa788a0819e72d65f0 Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Mon, 10 Mar 2025 07:49:09 +0100 Subject: [PATCH 02/11] tiny tweaks --- source/_integrations/philips_js.markdown | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index ff92e30d4b8..9a05efdaf0e 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -24,15 +24,17 @@ ha_integration_type: integration The `philips_js` platform allows you to control Philips TVs which expose the [jointSPACE](http://jointspace.sourceforge.net/) JSON-API. -**Differences between Android TVs and non-Android TVs** -1) Android TVs use `https://`, non-Android TV use `http://` -2) Android TVs primarily use port 1926, non-Android TV use port 1925 only + +**Differences between Android TVs and non-Android TVs**: + +1. Android TVs use `https://`, non-Android TV use `http://`. +2. Android TVs primarily use port 1926, non-Android TVs use port 1925 only. -For non-Android TV check if your TV responds to `http://IP_ADDRESS_OF_TV:1925/system`. +If you have a non-Android TV, check if your TV responds to `http://IP_ADDRESS_OF_TV:1925/system`. -For Android TV check if your TV responds to `https://IP_ADDRESS_OF_TV:1926/system`. +If you have an Android TV, check if your TV responds to `https://IP_ADDRESS_OF_TV:1926/system`. -If you get a response then this integration can be used. In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). +If you get a response, then this integration can be used. In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. This is true at least for some models before year 2011. Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. From ff6acd3f078ddf0e6e6202be243695fdbbca6a4c Mon Sep 17 00:00:00 2001 From: Stamatios Chrysinas Date: Mon, 10 Mar 2025 08:33:25 +0100 Subject: [PATCH 03/11] Update philips_js.markdown Use a Proper Heading Instead of Emphasized Text Instead of using bold text for the section title --- source/_integrations/philips_js.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 9a05efdaf0e..636e476a914 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -25,7 +25,7 @@ ha_integration_type: integration The `philips_js` platform allows you to control Philips TVs which expose the [jointSPACE](http://jointspace.sourceforge.net/) JSON-API. -**Differences between Android TVs and non-Android TVs**: +## Differences between Android TVs and non-Android TVs 1. Android TVs use `https://`, non-Android TV use `http://`. 2. Android TVs primarily use port 1926, non-Android TVs use port 1925 only. From c5b6a9c0e2b1b70d061cfaa59d7e5d6170cd9996 Mon Sep 17 00:00:00 2001 From: Stamatios Chrysinas Date: Mon, 10 Mar 2025 08:42:04 +0100 Subject: [PATCH 04/11] Update philips_js.markdown Made it generic, removed the Android, non-Android referneces --- source/_integrations/philips_js.markdown | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 636e476a914..38a9813759a 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -25,14 +25,18 @@ ha_integration_type: integration The `philips_js` platform allows you to control Philips TVs which expose the [jointSPACE](http://jointspace.sourceforge.net/) JSON-API. -## Differences between Android TVs and non-Android TVs +## Differences between TVs -1. Android TVs use `https://`, non-Android TV use `http://`. -2. Android TVs primarily use port 1926, non-Android TVs use port 1925 only. - -If you have a non-Android TV, check if your TV responds to `http://IP_ADDRESS_OF_TV:1925/system`. +1. Some TVs use `https://`, other TVs use `http://`. +2. Some TVs primarily use port 1926, other TVs use port 1925 only. -If you have an Android TV, check if your TV responds to `https://IP_ADDRESS_OF_TV:1926/system`. +## Check if this intergration can be used +Check if your TV responds to one of the following combinations: + +- `http://IP_ADDRESS_OF_TV:1925/system` +- `https://IP_ADDRESS_OF_TV:1925/system` +- `http://IP_ADDRESS_OF_TV:1926/system` +- `https://IP_ADDRESS_OF_TV:1926/system` If you get a response, then this integration can be used. In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. This is true at least for some models before year 2011. From a88fcb98e9b7e836cff4e1d97eee3aac1756a64d Mon Sep 17 00:00:00 2001 From: Stamatios Chrysinas Date: Mon, 10 Mar 2025 09:04:06 +0100 Subject: [PATCH 05/11] Update philips_js.markdown fixed misspelling, removed trailing white spaces --- source/_integrations/philips_js.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 38a9813759a..8c681879f2a 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -30,7 +30,7 @@ The `philips_js` platform allows you to control Philips TVs which expose the [jo 1. Some TVs use `https://`, other TVs use `http://`. 2. Some TVs primarily use port 1926, other TVs use port 1925 only. -## Check if this intergration can be used +## Check if this integration can be used Check if your TV responds to one of the following combinations: - `http://IP_ADDRESS_OF_TV:1925/system` From 1c040d5399f24b54271027dff5b3ba4b4237d71d Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Tue, 11 Mar 2025 08:58:42 +0100 Subject: [PATCH 06/11] convert to prereq section --- source/_integrations/philips_js.markdown | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 8c681879f2a..ddc73724ff6 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -25,20 +25,22 @@ ha_integration_type: integration The `philips_js` platform allows you to control Philips TVs which expose the [jointSPACE](http://jointspace.sourceforge.net/) JSON-API. -## Differences between TVs +## Prerequisites -1. Some TVs use `https://`, other TVs use `http://`. -2. Some TVs primarily use port 1926, other TVs use port 1925 only. +Before adding the integration, it is worth checking if this integration works for you. As there are differences between TVs, you may need to try different addresses: -## Check if this integration can be used -Check if your TV responds to one of the following combinations: +- Some TVs use `https://`, other TVs use `http://`. +- Some TVs primarily use port 1926, other TVs use port 1925 only. -- `http://IP_ADDRESS_OF_TV:1925/system` -- `https://IP_ADDRESS_OF_TV:1925/system` -- `http://IP_ADDRESS_OF_TV:1926/system` -- `https://IP_ADDRESS_OF_TV:1926/system` +### Check if this integration can be used -If you get a response, then this integration can be used. In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). +1. Check if your TV responds to one of the following combinations: + - `http://IP_ADDRESS_OF_TV:1925/system` + - `https://IP_ADDRESS_OF_TV:1925/system` + - `http://IP_ADDRESS_OF_TV:1926/system` + - `https://IP_ADDRESS_OF_TV:1926/system` +2. If you get a response, then this integration can be used. + - In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. This is true at least for some models before year 2011. Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. From 90151973e60d33faab6ec088277f620e6110e25e Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Tue, 11 Mar 2025 09:08:56 +0100 Subject: [PATCH 07/11] Apply suggestions from code review --- source/_integrations/philips_js.markdown | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index ddc73724ff6..fbef030e526 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -41,9 +41,10 @@ Before adding the integration, it is worth checking if this integration works fo - `https://IP_ADDRESS_OF_TV:1926/system` 2. If you get a response, then this integration can be used. - In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). -For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. This is true at least for some models before year 2011. - -Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. +3. For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). + - Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. + - This is true at least for some models before year 2011. + - Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. {% include integrations/config_flow.md %} From 2b88698e9a42a4766ee68d11cf994cfa9a4c6e9c Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Tue, 11 Mar 2025 09:09:20 +0100 Subject: [PATCH 08/11] Update source/_integrations/philips_js.markdown --- source/_integrations/philips_js.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index fbef030e526..55240c8ca58 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -44,7 +44,7 @@ Before adding the integration, it is worth checking if this integration works fo 3. For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). - Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. - This is true at least for some models before year 2011. - - Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. + - Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. {% include integrations/config_flow.md %} From 8f8e686f1629695ab12377f86414c8823621211d Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Tue, 11 Mar 2025 09:11:46 +0100 Subject: [PATCH 09/11] fix indents Co-authored-by: Joakim Plate --- source/_integrations/philips_js.markdown | 2 -- 1 file changed, 2 deletions(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 55240c8ca58..973efe53d50 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -36,8 +36,6 @@ Before adding the integration, it is worth checking if this integration works fo 1. Check if your TV responds to one of the following combinations: - `http://IP_ADDRESS_OF_TV:1925/system` - - `https://IP_ADDRESS_OF_TV:1925/system` - - `http://IP_ADDRESS_OF_TV:1926/system` - `https://IP_ADDRESS_OF_TV:1926/system` 2. If you get a response, then this integration can be used. - In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). From 50ad49d80274de84f4941163e72698dab690b6b6 Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Tue, 11 Mar 2025 09:12:50 +0100 Subject: [PATCH 10/11] typo --- source/_integrations/philips_js.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 973efe53d50..33949a18cd0 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -39,7 +39,7 @@ Before adding the integration, it is worth checking if this integration works fo - `https://IP_ADDRESS_OF_TV:1926/system` 2. If you get a response, then this integration can be used. - In the response, you should also be able to see the version of the API the TV uses (`"api_version":{"Major":6...`). -3. For older TVs follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). +3. For older TVs, follow instructions on how to activate the API and if your model is supported [here](http://jointspace.sourceforge.net/download.html). - Note that not all listed, jointSPACE-enabled devices will have JSON-interface running on port 1925. - This is true at least for some models before year 2011. - Also, note that version 6 of the API needs to be authenticated by a PIN code displayed on your TV. From 533f493a337da973ba0a247e77de1b21126f91de Mon Sep 17 00:00:00 2001 From: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> Date: Tue, 11 Mar 2025 09:29:34 +0100 Subject: [PATCH 11/11] implement review feedback --- source/_integrations/philips_js.markdown | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source/_integrations/philips_js.markdown b/source/_integrations/philips_js.markdown index 33949a18cd0..94bac4dbaf5 100644 --- a/source/_integrations/philips_js.markdown +++ b/source/_integrations/philips_js.markdown @@ -29,8 +29,7 @@ The `philips_js` platform allows you to control Philips TVs which expose the [jo Before adding the integration, it is worth checking if this integration works for you. As there are differences between TVs, you may need to try different addresses: -- Some TVs use `https://`, other TVs use `http://`. -- Some TVs primarily use port 1926, other TVs use port 1925 only. +- Some TVs use `https://` and port 1926, other TVs use `http://` and port 1925. ### Check if this integration can be used