From f00ab82f86206610be3274ef3048b18050835541 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Wed, 5 Oct 2022 12:37:32 +0200 Subject: [PATCH] Devcontainer improvements (#24356) --- .devcontainer/devcontainer.json | 14 ++++++++------ .vscode/extensions.json | 4 ++++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 806ae1c93b0..f0edac50861 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -9,22 +9,24 @@ } }, "appPort": [4000], - "postCreateCommand": "bundle install && npm install", + "onCreateCommand": "bundle install && npm install", "containerEnv": { "DEVCONTAINER": "true" }, "extensions": [ "davidanson.vscode-markdownlint", "editorconfig.editorconfig", + "GitHub.vscode-pull-request-github", "mrmlnc.vscode-scss", "rebornix.Ruby", "streetsidesoftware.code-spell-checker", + "taichi.vscode-textlint", "yzhang.markdown-all-in-one" ], "settings": { - "editor.rulers": [80, 100, 120], "editor.renderWhitespace": "boundary", - "errorLens.gutterIconsEnabled": true, - "errorLens.addAnnotationTextPrefixes": false, - "errorLens.enabledDiagnosticLevels": ["error", "warning"], - "terminal.integrated.shell.linux": "/usr/bin/zsh" + "editor.rulers": [80, 100, 120], + "gitlens.showWelcomeOnInstall": false, + "gitlens.showWhatsNewAfterUpgrades": false, + "terminal.integrated.shell.linux": "/usr/bin/zsh", + "workbench.startupEditor": "none" } } diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 5f55e50474f..199390c8fce 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -2,7 +2,11 @@ "recommendations": [ "davidanson.vscode-markdownlint", "editorconfig.editorconfig", + "GitHub.vscode-pull-request-github", + "mrmlnc.vscode-scss", + "rebornix.Ruby", "streetsidesoftware.code-spell-checker", + "taichi.vscode-textlint", "yzhang.markdown-all-in-one" ] } \ No newline at end of file