diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 9e9a045776..dd04ffd58f 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -4,6 +4,7 @@ # menu options using "make menuconfig" and by running "make" with appropriate # packages enabled. +import os import re from checkpackagelib.base import _CheckFunction @@ -165,10 +166,9 @@ class PackageHeader(_CheckFunction): class RemoveDefaultPackageSourceVariable(_CheckFunction): packages_that_may_contain_default_source = ["binutils", "gcc", "gdb"] - PACKAGE_NAME = re.compile("/([^/]+)\.mk") def before(self): - package = self.PACKAGE_NAME.search(self.filename).group(1) + package, _ = os.path.splitext(os.path.basename(self.filename)) package_upper = package.replace("-", "_").upper() self.package = package self.FIND_SOURCE = re.compile( @@ -238,11 +238,10 @@ class TypoInPackageVariable(_CheckFunction): "TARGET_FINALIZE_HOOKS", "TARGETS_ROOTFS", "XTENSA_CORE_NAME"])) - PACKAGE_NAME = re.compile("/([^/]+)\.mk") VARIABLE = re.compile("^([A-Z0-9_]+_[A-Z0-9_]+)\s*(\+|)=") def before(self): - package = self.PACKAGE_NAME.search(self.filename).group(1) + package, _ = os.path.splitext(os.path.basename(self.filename)) package = package.replace("-", "_").upper() # linux tools do not use LINUX_TOOL_ prefix for variables package = package.replace("LINUX_TOOL_", "") diff --git a/utils/checkpackagelib/lib_patch.py b/utils/checkpackagelib/lib_patch.py index 453b782e6c..438353ad3b 100644 --- a/utils/checkpackagelib/lib_patch.py +++ b/utils/checkpackagelib/lib_patch.py @@ -3,6 +3,7 @@ # functions don't need to check for things already checked by running # "make package-dirclean package-patch". +import os import re from checkpackagelib.base import _CheckFunction @@ -10,10 +11,10 @@ from checkpackagelib.lib import NewlineAtEof # noqa: F401 class ApplyOrder(_CheckFunction): - APPLY_ORDER = re.compile("/\d{1,4}-[^/]*$") + APPLY_ORDER = re.compile("\d{1,4}-[^/]*$") def before(self): - if not self.APPLY_ORDER.search(self.filename): + if not self.APPLY_ORDER.match(os.path.basename(self.filename)): return ["{}:0: use name -.patch " "({}#_providing_patches)" .format(self.filename, self.url_to_manual)]