From 37e8a054f29f927d72c3a4d5c82f0d4faac53e70 Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Tue, 28 Aug 2018 22:59:24 +0200 Subject: [PATCH] cutelyst: link with libatomic when needed On some architectures, atomic binutils are provided by the libatomic library from gcc. Linking with libatomic is therefore necessary, otherwise the build fails with: sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line This is often for example the case on sparcv8 32 bit. This atomic dependency is due to Qt >= 5.8, pkconfig can't be used as Qt5 pc files does not mention this dependency Fixes: - http://autobuild.buildroot.net/results/9e307ab9c7067b26d7b33a572204394808e25772 Signed-off-by: Fabrice Fontaine Signed-off-by: Thomas Petazzoni --- package/cutelyst/cutelyst.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/cutelyst/cutelyst.mk b/package/cutelyst/cutelyst.mk index e8695a7b3a..8e117e3286 100644 --- a/package/cutelyst/cutelyst.mk +++ b/package/cutelyst/cutelyst.mk @@ -16,6 +16,11 @@ CUTELYST_CONF_OPTS += \ -DPLUGIN_CSRFPROTECTION=ON \ -DPLUGIN_VIEW_GRANTLEE=OFF +# Qt 5.8 needs atomics, which on various architectures are in -latomic +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC)$(BR2_PACKAGE_QT5_VERSION_LATEST),yy) +CUTELYST_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -latomic" +endif + ifeq ($(BR2_PACKAGE_LIBPWQUALITY),y) CUTELYST_CONF_OPTS += -DPLUGIN_VALIDATOR_PWQUALITY=ON CUTELYST_DEPENDENCIES += libpwquality