From 5401ccaf6d06f3140df45f70cd9746de7f870125 Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sun, 5 Oct 2014 11:35:14 +0200 Subject: [PATCH] package-infra: comment why all checks are done in pkg-generic [Thomas: fix duplicate -> duplicating.] Reported-by: Thomas Petazzoni Signed-off-by: "Yann E. MORIN" Cc: Thomas De Schampheleire Acked-by: Thomas De Schampheleire Signed-off-by: Thomas Petazzoni --- package/pkg-generic.mk | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index ec8afdd9bc..f09f83e6e1 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -702,7 +702,11 @@ $$(foreach pkg,$$($(2)_PROVIDES),\ $$(eval $$(call virt-provides-single,$$(pkg),$$(call UPPERCASE,$$(pkg)),$(1))$$(sep))) endif -# Ensure unified variable name conventions between all packages +# Ensure unified variable name conventions between all packages Some +# of the variables are used by more than one infrastructure; so, +# rather than duplicating the checks in each infrastructure, we check +# all variables here in pkg-generic, even though pkg-generic should +# have no knowledge of infra-specific variables. $(eval $(call check-deprecated-variable,$(2)_MAKE_OPT,$(2)_MAKE_OPTS)) $(eval $(call check-deprecated-variable,$(2)_INSTALL_OPT,$(2)_INSTALL_OPTS)) $(eval $(call check-deprecated-variable,$(2)_INSTALL_TARGET_OPT,$(2)_INSTALL_TARGET_OPTS))