package/acpid: refactor init script

Adapt the format to the current template, used in other init scripts.

Move the one socond delay in restart to stop, giving acpid time to send
dying gasp to syslog.

Users willing to add start arguments can set the ACPID_ARGS variable in
/etc/default/acpid instead of rewriting the init script.

Signed-off-by: Carlos Santos <unixmania@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

package/acpid/S02acpid

@@ -1,22 +1,53 @@
 #!/bin/sh
 
-case "$1" in
+DAEMON="acpid"
-	start)
+EXEC="/usr/sbin/$DAEMON"
-		printf "Starting acpid: "
+PIDFILE="/var/run/$DAEMON.pid"
-		start-stop-daemon -S -q -m -b -p /var/run/acpid.pid --exec /usr/sbin/acpid -- -n
+
-		[ $? = 0 ] && echo "OK" || echo "FAIL"
+ACPID_ARGS=""
-		;;
+
-	stop)
+# shellcheck source=/dev/null
-		printf "Stopping acpid: "
+[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON"
-		start-stop-daemon -K -q -p /var/run/acpid.pid
+
-		[ $? = 0 ] && echo "OK" || echo "FAIL"
+start() {
-		;;
+	printf 'Starting %s: ' "$DAEMON"
-	restart)
+	# shellcheck disable=SC2086 # we need the word splitting
-		"$0" stop
+	start-stop-daemon -S -q -p "$PIDFILE" -x "$EXEC" \
+		-- -n $ACPID_ARGS
+	status=$?
+	if [ "$status" -eq 0 ]; then
+		echo "OK"
+	else
+		echo "FAIL"
+	fi
+	return "$status"
+}
+
+stop() {
+	printf 'Stopping %s: ' "$DAEMON"
+	start-stop-daemon -K -q -p "$PIDFILE" -x "$EXEC"
+	status=$?
+	if [ "$status" -eq 0 ]; then
+		# Give acpid time to send dying gasp to syslog
 		sleep 1
-		"$0" start
+		echo "OK"
-		;;
+	else
+		echo "FAIL"
+	fi
+	return "$status"
+}
+
+restart() {
+	stop
+	start
+}
+
+case "$1" in
+	start|stop|restart)
+		"$1";;
+	reload)
+		restart;;
 	*)
-		echo "Usage: $0 {start|stop|restart}"
+		echo "Usage: $0 {start|stop|restart|reload}"
-		;;
+		exit 1
 esac