From 104f802df1414515028a95f7081a33e87ffb02fb Mon Sep 17 00:00:00 2001 From: Bruce MacDonald Date: Tue, 29 Apr 2025 16:57:41 -0700 Subject: [PATCH] remove todos --- model/models/qwen25vl/model_vision.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/model/models/qwen25vl/model_vision.go b/model/models/qwen25vl/model_vision.go index 4d9cb48a9..306de8780 100644 --- a/model/models/qwen25vl/model_vision.go +++ b/model/models/qwen25vl/model_vision.go @@ -1,6 +1,7 @@ package qwen25vl import ( + "fmt" "math" "github.com/ollama/ollama/fs" @@ -251,7 +252,7 @@ func (m *VisionModel) positionalEmbedding(ctx ml.Context, grid *Grid) ml.Tensor } freqs, err := ctx.Input().FromFloatSlice(freqVals, freq, maxGridSize) if err != nil { - panic(err) // TODO: handle error + panic(fmt.Errorf("failed to create tensor from frequencies: %w", err)) } // Create position coordinates (y,x pairs) for the grid @@ -264,7 +265,7 @@ func (m *VisionModel) positionalEmbedding(ctx ml.Context, grid *Grid) ml.Tensor } pos, err := ctx.Input().FromIntSlice(coords, 2, grid.Width, grid.Height) if err != nil { - panic(err) // TODO: handle error + panic(fmt.Errorf("failed to create tensor from positions: %w", err)) } // Reshape and permute positions to match spatial merging pattern