From 309307c8f98a79f135b838c7905caac8defd3a47 Mon Sep 17 00:00:00 2001
From: Josh Yan <jyan00017@gmail.com>
Date: Wed, 17 Jul 2024 10:46:50 -0700
Subject: [PATCH] update test, remove comments

---
 llm/gguf.go      | 3 +--
 llm/gguf_test.go | 9 +++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/llm/gguf.go b/llm/gguf.go
index d57b6219f..e92c3b121 100644
--- a/llm/gguf.go
+++ b/llm/gguf.go
@@ -227,7 +227,6 @@ func (llm *gguf) Decode(rs io.ReadSeeker) error {
 			return fmt.Errorf("failed to read tensor offset: %w", err)
 		}
 
-		fmt.Println("tensor", name, shape, kind, offset)
 		tensor := Tensor{
 			Name:   name,
 			Kind:   kind,
@@ -765,9 +764,9 @@ func (gguf GGUFWriter) WriteTo(w io.Writer) (int64, error) {
 	slices.Sort(keys)
 
 	for _, key := range keys {
-		fmt.Println(key)
 		switch key {
 		case "general.parameter_count":
+			// don't write general param count as its added in by us
 			continue
 		default:
 			if err := ggufWriteKV(wo, key, gguf.KV[key]); err != nil {
diff --git a/llm/gguf_test.go b/llm/gguf_test.go
index e2ac3d982..c3284395a 100644
--- a/llm/gguf_test.go
+++ b/llm/gguf_test.go
@@ -14,11 +14,12 @@ import (
 
 // TestGGUFDecode tests the decoding and rewriting of (unsorted) GGUF files
 // To run, add GGUF files to /llm/testdata and add the name of the file to the tests slice
-// Should comment //sort.Sort(tensors) in gguf.go
 // This creates a temporary file in /llm/testdata that will deleted only if the test passes
+// Note: map[Tensor.Name + " offset"] is commented since sorting will reorder the tensors
+// Comment out sort.Sort(gguf.Tensors) in gguf.go to test offsets
 func TestGGUFRewrite(t *testing.T) {
 	tests := []string{
-		"nutiny.gguf",
+		"phi3.gguf",
 	}
 
 	for i := range tests {
@@ -112,7 +113,7 @@ func compareGGML(t *testing.T, gotGGML, wantGGML *GGML, f *os.File, f2 *os.File)
 
 		got[tensor.Name] = fmt.Sprintf("%x", sha256sum.Sum(nil))
 		got[tensor.Name+" size"] = fmt.Sprintf("%d", s)
-		got[tensor.Name+" offset"] = fmt.Sprintf("%v", tensor.Offset)
+		// got[tensor.Name+" offset"] = fmt.Sprintf("%v", tensor.Offset)
 	}
 
 	for _, tensor := range wantTensors {
@@ -126,7 +127,7 @@ func compareGGML(t *testing.T, gotGGML, wantGGML *GGML, f *os.File, f2 *os.File)
 
 		want[tensor.Name] = fmt.Sprintf("%x", sha256sum.Sum(nil))
 		want[tensor.Name+" size"] = fmt.Sprintf("%d", s)
-		want[tensor.Name+" offset"] = fmt.Sprintf("%v", tensor.Offset)
+		// want[tensor.Name+" offset"] = fmt.Sprintf("%v", tensor.Offset)
 	}
 	return got, want
 }