jeans/ollama
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

.github/workflows: swap order of go test and golangci-lint (#9389)

Browse Source 
The linter is secondary to the tests, so it should run after the tests,
exposing test failures faster.
This commit is contained in:
Blake Mizerany 2025-02-26 23:03:48 -08:00 committed by GitHub
parent a5272130c4
commit 76e903cf9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
.github/workflows/test.yaml vendored
View File

@ -190,6 +190,20 @@ jobs:
go-version-file: go.mod go-version-file: go.mod
# It is tempting to run this in a platform independent way, but the past
# shows this codebase will see introductions of platform specific code
# generation, and so we need to check this per platform to ensure we
# don't abuse go generate on specific platforms.
- name: check that 'go generate' is clean
if: always()
run: |
go generate ./...
git diff --name-only --exit-code || (echo "Please run 'go generate ./...'." && exit 1)
- name: go test
if: always()
run: go test -count=1 -benchtime=1x ./...
# TODO(bmizerany): replace this heavy tool with just the # TODO(bmizerany): replace this heavy tool with just the
# tools/checks/binaries we want and then make them all run in parallel # tools/checks/binaries we want and then make them all run in parallel
# across jobs, not on a single tiny vm on Github Actions. # across jobs, not on a single tiny vm on Github Actions.
@ -197,21 +211,6 @@ jobs:
with: with:
args: --timeout 10m0s -v args: --timeout 10m0s -v
- name: go test
# Do not skip tests in the face of linter errors, or 'go mod tidy'
# checks, which are secondary to the tests. Tests trump linters.
if: always()
run: go test -count=1 -benchtime=1x ./...
# It is tempting to run this in a platform independent way, but the past
# shows this codebase will see introductions of platform specific code
# generation, and so we need to check this per platform to ensure we
# don't abuse go generate on specific platforms.
- name: check that 'go generate' is clean
run: |
go generate ./...
git diff --name-only --exit-code || (echo "Please run 'go generate ./...'." && exit 1)
- name: cache save - name: cache save
# Always save the cache, even if the job fails. The artifacts produced # Always save the cache, even if the job fails. The artifacts produced
# during the building of test binaries are not all for naught. They can # during the building of test binaries are not all for naught. They can