From 7e13f568dc632fa61c8f92605a34c5700e834f44 Mon Sep 17 00:00:00 2001
From: Jesse Gross <jesse@ollama.com>
Date: Tue, 4 Feb 2025 19:49:34 -0800
Subject: [PATCH] backend: Don't return an error on Close

It is not common to return errors with close/free operations - most
people won't check it and even if they did there's probably not much
that can do. It's better to not give implementations false expectations.
---
 ml/backend.go           | 2 +-
 ml/backend/ggml/ggml.go | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/ml/backend.go b/ml/backend.go
index 855ca245e..2bf3e8540 100644
--- a/ml/backend.go
+++ b/ml/backend.go
@@ -50,7 +50,7 @@ type Context interface {
 
 	Forward(Tensor)
 	Compute(Tensor) Tensor
-	Close() error
+	Close()
 }
 
 type Tensor interface {
diff --git a/ml/backend/ggml/ggml.go b/ml/backend/ggml/ggml.go
index 8274f3ebb..d34fef3a6 100644
--- a/ml/backend/ggml/ggml.go
+++ b/ml/backend/ggml/ggml.go
@@ -306,10 +306,9 @@ func (c Context) FromIntSlice(s []int32, shape ...int) (ml.Tensor, error) {
 	return fromSlice(c, s, shape, C.GGML_TYPE_I32)
 }
 
-func (c *Context) Close() error {
+func (c *Context) Close() {
 	C.ggml_backend_sched_free(c.sched)
 	C.ggml_free(c.ctx)
-	return nil
 }
 
 type Tensor struct {