From ba9ec3d05ed47b243389f8273d160329e8964362 Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Thu, 20 Feb 2025 11:52:25 -0800 Subject: [PATCH] ci: use clang for windows cpu builds clang outputs are faster. we were previously building with clang via gcc wrapper in cgo but this was missed during the build updates so there was a drop in performance --- .github/workflows/release.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 37ac7e45e..37d525e91 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -160,6 +160,10 @@ jobs: echo "$hipPath\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append echo "CC=$hipPath\bin\clang.exe" | Out-File -FilePath $env:GITHUB_ENV -Append echo "CXX=$hipPath\bin\clang++.exe" | Out-File -FilePath $env:GITHUB_ENV -Append + - if: matrix.preset == 'CPU' + run: | + echo "CC=clang.exe" | Out-File -FilePath $env:GITHUB_ENV -Append + echo "CXX=clang++.exe" | Out-File -FilePath $env:GITHUB_ENV -Append - if: ${{ !cancelled() && steps.cache-install.outputs.cache-hit != 'true' }} uses: actions/cache/save@v4 with: