jeans/openHASP
jeans/openHASP
1
0
Fork 0
mirror of https://github.com/HASwitchPlate/openHASP.git synced 2025-07-28 13:46:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Http password could be overwritten by 8 asterisks

Browse Source
This commit is contained in:
fvanroie 2022-02-05 03:13:54 +01:00
parent 73fd2918ff
commit b4ac68eee5
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/sys/svc/hasp_http.cpp
View File

@ -534,7 +534,8 @@ static void webHandleApiConfig()
return; return;
} }
if(!settings[FPSTR(FP_CONFIG_PASS)].isNull()) { // Mask non-blank passwords
if(!settings[FPSTR(FP_CONFIG_PASS)].isNull() && settings[FPSTR(FP_CONFIG_PASS)].as<String>().length() != 0) {
settings[FPSTR(FP_CONFIG_PASS)] = D_PASSWORD_MASK; settings[FPSTR(FP_CONFIG_PASS)] = D_PASSWORD_MASK;
} }
@ -2458,7 +2459,8 @@ bool httpSetConfig(const JsonObject& settings)
strncpy(http_config.username, settings[FPSTR(FP_CONFIG_USER)], sizeof(http_config.username)); strncpy(http_config.username, settings[FPSTR(FP_CONFIG_USER)], sizeof(http_config.username));
} }
if(!settings[FPSTR(FP_CONFIG_PASS)].isNull()) { if(!settings[FPSTR(FP_CONFIG_PASS)].isNull() &&
settings[FPSTR(FP_CONFIG_PASS)].as<String>() != String(FPSTR(D_PASSWORD_MASK))) {
changed |= strcmp(http_config.password, settings[FPSTR(FP_CONFIG_PASS)]) != 0; changed |= strcmp(http_config.password, settings[FPSTR(FP_CONFIG_PASS)]) != 0;
strncpy(http_config.password, settings[FPSTR(FP_CONFIG_PASS)], sizeof(http_config.password)); strncpy(http_config.password, settings[FPSTR(FP_CONFIG_PASS)], sizeof(http_config.password));
} }