From def80b9bbc9c1b7816d572278ac59a3131d25a18 Mon Sep 17 00:00:00 2001
From: Stefan Agner <stefan@agner.ch>
Date: Thu, 19 May 2022 21:47:27 +0200
Subject: [PATCH] Make NTP dispatch script executable (#1798) (#1933)

* Make NTP dispatch script executable (#1798)

* Address shellcheck issues
---
 .../usr/lib/NetworkManager/dispatcher.d/10-ntp             | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
 mode change 100644 => 100755 buildroot-external/rootfs-overlay/usr/lib/NetworkManager/dispatcher.d/10-ntp

diff --git a/buildroot-external/rootfs-overlay/usr/lib/NetworkManager/dispatcher.d/10-ntp b/buildroot-external/rootfs-overlay/usr/lib/NetworkManager/dispatcher.d/10-ntp
old mode 100644
new mode 100755
index 9c815605d..425786bfc
--- a/buildroot-external/rootfs-overlay/usr/lib/NetworkManager/dispatcher.d/10-ntp
+++ b/buildroot-external/rootfs-overlay/usr/lib/NetworkManager/dispatcher.d/10-ntp
@@ -11,7 +11,7 @@ timesyncd_dhcp_ntp_remove() {
 }
 
 timesyncd_dhcp_ntp_add() {
-  mkdir -p $(dirname $TIMESYNCD_CONF)
+  mkdir -p "$(dirname $TIMESYNCD_CONF)"
 
   echo '[Time]' > ${TIMESYNCD_CONF}
   echo "NTP=${DHCP4_NTP_SERVERS}" >> ${TIMESYNCD_CONF}
@@ -19,12 +19,13 @@ timesyncd_dhcp_ntp_add() {
   systemctl restart systemd-timesyncd.service
 }
 
+# shellcheck disable=SC2034
 INTERFACE=${1}
 ACTION=${2}
 
 case ${ACTION} in
   up|down|dhcp4-change)
-    if [ ! -z "${DHCP4_NTP_SERVERS}" ]
+    if [ -n "${DHCP4_NTP_SERVERS}" ]
     then
       timesyncd_dhcp_ntp_add
       RETURN_CODE=$?
@@ -34,7 +35,7 @@ case ${ACTION} in
     fi
   ;;
   *)
-    $RETURN_CODE=0
+    RETURN_CODE=0
     ;;
 esac