jeans/supervisor
jeans/supervisor
1
0
Fork 0
mirror of https://github.com/home-assistant/supervisor.git synced 2025-07-10 02:36:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't warn for removing unstarted jobs (#4632)

Browse Source
This commit is contained in:
Mike Degatano 2023-10-19 11:35:16 -04:00 committed by GitHub
parent b1010c3c61
commit 010043f116
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
supervisor/jobs/__init__.py
View File

@ -190,7 +190,7 @@ class JobManager(FileConfiguration, CoreSysAttributes):
if job.uuid not in self._jobs: if job.uuid not in self._jobs:
raise JobNotFound(f"Could not find job {job.name}", _LOGGER.error) raise JobNotFound(f"Could not find job {job.name}", _LOGGER.error)
if not job.done: if job.done is False:
_LOGGER.warning("Removing incomplete job %s from job manager", job.name) _LOGGER.warning("Removing incomplete job %s from job manager", job.name)
del self._jobs[job.uuid] del self._jobs[job.uuid]

11
tests/jobs/test_job_manager.py
View File

@ -22,12 +22,19 @@ async def test_add_job(coresys: CoreSys):
async def test_remove_job_directly(coresys: CoreSys, caplog: pytest.LogCaptureFixture): async def test_remove_job_directly(coresys: CoreSys, caplog: pytest.LogCaptureFixture):
"""Test removing jobs from manager.""" """Test removing jobs from manager."""
job = coresys.jobs.new_job(TEST_JOB) job = coresys.jobs.new_job(TEST_JOB)
assert job in coresys.jobs.jobs assert job in coresys.jobs.jobs
coresys.jobs.remove_job(job) coresys.jobs.remove_job(job)
assert job not in coresys.jobs.jobs assert job not in coresys.jobs.jobs
assert f"Removing incomplete job {job.name}" in caplog.text assert f"Removing incomplete job {job.name}" not in caplog.text
job = coresys.jobs.new_job(TEST_JOB)
assert job in coresys.jobs.jobs
with job.start():
coresys.jobs.remove_job(job)
assert job not in coresys.jobs.jobs
assert f"Removing incomplete job {job.name}" in caplog.text
async def test_job_done(coresys: CoreSys): async def test_job_done(coresys: CoreSys):