jeans/supervisor
jeans/supervisor
1
0
Fork 0
mirror of https://github.com/home-assistant/supervisor.git synced 2025-07-09 10:16:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle multiple suggestions with different references (#3817)

Browse Source
This commit is contained in:
Mike Degatano 2022-08-25 10:09:25 -04:00 committed by GitHub
parent d5f9fcfdc7
commit 32d65722e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
supervisor/resolution/fixup.py
View File

@ -70,4 +70,4 @@ class ResolutionFixup(CoreSysAttributes):
async def apply_fixup(self, suggestion: Suggestion) -> None: async def apply_fixup(self, suggestion: Suggestion) -> None:
"""Apply a fixup for a suggestion.""" """Apply a fixup for a suggestion."""
for fix in self.fixes_for_suggestion(suggestion): for fix in self.fixes_for_suggestion(suggestion):
await fix() await fix(suggestion)

7
supervisor/resolution/fixups/base.py
View File

@ -17,10 +17,13 @@ class FixupBase(ABC, CoreSysAttributes):
"""Initialize the fixup class.""" """Initialize the fixup class."""
self.coresys = coresys self.coresys = coresys
async def __call__(self) -> None: async def __call__(self, fixing_suggestion: Suggestion | None = None) -> None:
"""Execute the evaluation.""" """Execute the evaluation."""
if not fixing_suggestion:
# Get suggestion to fix # Get suggestion to fix
fixing_suggestion: Suggestion | None = next(iter(self.all_suggestions), None) fixing_suggestion: Suggestion | None = next(
iter(self.all_suggestions), None
)
# No suggestion # No suggestion
if fixing_suggestion is None: if fixing_suggestion is None:

19
tests/resolution/test_resolution_manager.py
View File

@ -220,3 +220,22 @@ async def test_events_on_issue_changes(coresys: CoreSys):
change_handler.assert_not_called() change_handler.assert_not_called()
remove_handler.assert_called_once_with(issue) remove_handler.assert_called_once_with(issue)
async def test_resolution_apply_suggestion_multiple_copies(coresys: CoreSys):
"""Test resolution manager applies correct suggestion when has multiple that differ by reference."""
coresys.resolution.suggestions = remove_store_1 = Suggestion(
SuggestionType.EXECUTE_REMOVE, ContextType.STORE, "repo_1"
)
coresys.resolution.suggestions = remove_store_2 = Suggestion(
SuggestionType.EXECUTE_REMOVE, ContextType.STORE, "repo_2"
)
coresys.resolution.suggestions = remove_store_3 = Suggestion(
SuggestionType.EXECUTE_REMOVE, ContextType.STORE, "repo_3"
)
await coresys.resolution.apply_suggestion(remove_store_2)
assert remove_store_1 in coresys.resolution.suggestions
assert remove_store_2 not in coresys.resolution.suggestions
assert remove_store_3 in coresys.resolution.suggestions